-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: mark assert.CallTracker experimental #33124
Conversation
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <[email protected]>
Won't block this but I don't see it as strictly necessary. If additional useful changes are to be made, then let's identify those and get them in. It's still brand new API that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this is a very good idea. My big concern with pretty much all new APIS is that we may find that we've made an API design mistake. Once people start using it, it may become apparent that there is a more ergonomic way to do things. And I'm also often concerned that we may not name APIs the best we can. Let's leave ourselves a little wiggle room for a few releases. If it goes out as Experimental in, say, 14.2.0, we can always remove Experimental in a later 14.x release.
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33124 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Landed in c81e5f6 |
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33124 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
This is blocked until |
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33124 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Some details might still change and it would be good to get feedback
from users before we mark this as stable.
It might for example be good to rework the
stack
property.Signed-off-by: Ruben Bridgewater [email protected]
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes