Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix fs.read when passing null value #32479

Closed
wants to merge 1 commit into from
Closed

lib: fix fs.read when passing null value #32479

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Mar 25, 2020 •
edited
Loading

it shouldn't use the default value when user passing null on options

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Mar 25, 2020
@himself65 himself65 force-pushed the 20200325-fs branch 2 times, most recently from 7ac2c95 to 976b3f2 Compare March 25, 2020 08:45
@himself65 himself65 changed the title lib: fix fs.read default value lib: fix fs.read when passing null value Mar 25, 2020
@himself65 himself65 mentioned this pull request Mar 25, 2020
Closed
4 tasks
@jasnell
Copy link
Member

jasnell commented Mar 25, 2020

Does this need a test?

@himself65
Copy link
Member Author

himself65 commented Mar 25, 2020 •
edited
Loading

Does this need a test?

Better than nothing. I will.

@himself65 himself65 force-pushed the 20200325-fs branch 5 times, most recently from 1e1f29a to 66c46bf Compare March 25, 2020 17:52
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30184/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30204/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30209/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30228/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30238/

addaleax pushed a commit that referenced this pull request Mar 30, 2020
@himself65 @addaleax
fs: fix fs.read when passing null value
defbc2e 
PR-URL: #32479
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@addaleax
Copy link
Member

Landed in defbc2e and updated the commit message while landing

@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@himself65 @addaleax
fs: fix fs.read when passing null value
b8b8e82 
PR-URL: #32479
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@himself65 @targos
fs: fix fs.read when passing null value
c7a2bae 
PR-URL: nodejs#32479
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@himself65 @targos
fs: fix fs.read when passing null value
bde0837 
PR-URL: #32479
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
This was referenced Apr 19, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lholmquist lholmquist lholmquist approved these changes

@addaleax addaleax addaleax approved these changes

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@himself65 @jasnell @nodejs-github-bot @addaleax @evanlucas @lholmquist @cjihrig @targos