Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13.x backport] writeable stream: group all properties #32164

Closed
wants to merge 1 commit into from
Closed

[v13.x backport] writeable stream: group all properties #32164

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 9, 2020 •
edited
Loading

PR-URL: #31187

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Mar 9, 2020
@ronag ronag requested a review from MylesBorins March 9, 2020 22:42
@ronag ronag changed the title [v13.x backport] https://github.com/nodejs/node/pull/31187 [v13.x backport] writeable stream: group all properties Mar 9, 2020
@antsmartian @ronag
stream: combine properties using defineProperties
abd0fbb 
PR-URL: nodejs#31187
Refs: nodejs#31144
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Backport-PR-URL: nodejs#32164
@ronag ronag mentioned this pull request Mar 9, 2020
Closed
7 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29684/

mcollina
mcollina approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@antsmartian @MylesBorins
stream: combine properties using defineProperties
90a4d43 
Backport-PR-URL: #32164
PR-URL: #31187
Refs: #31144
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 90a4d43

targos pushed a commit that referenced this pull request Apr 20, 2020
@antsmartian @targos
stream: combine properties using defineProperties
8d1eeb1 
Backport-PR-URL: #32164
PR-URL: #31187
Refs: #31144
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antsmartian antsmartian antsmartian approved these changes

@mcollina mcollina mcollina approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @MylesBorins @mcollina @antsmartian