[v12.x backport] http2: make HTTP2ServerResponse more streams compliant #31444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP2ServerResponse.write would behave differently than both http1 and streams. This PR makes it more compliant with stream.Writable behaviour. PR-URL: nodejs#30964 Refs: nodejs#29529 Backport-PR-URL: nodejs#31444
nodejs-github-bot
added
http2
|
(I don't yet have authority to run node-test-pull-request on this) |
|
Test at https://ci.nodejs.org/job/node-test-binary-windows-js-suites/1213/RUN_SUBSET=0,nodes=win2016-COMPILED_BY-vs2017/testReport/(root)/test/sequential_test_worker_prof_/ showing an error message of |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 30, 2020
HTTP2ServerResponse.write would behave differently than both http1 and streams. This PR makes it more compliant with stream.Writable behaviour. Backport-PR-URL: #31444 PR-URL: #30964 Refs: #29529 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
landed in f63e440 The flakes are not a big deal for CI, thanks for pointing it out. I udpated the commit message while landing, in the future it is fine to keep the original commit message and we can add a |
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
HTTP2ServerResponse.write would behave differently than both http1 and streams. This PR makes it more compliant with stream.Writable behaviour. Backport-PR-URL: #31444 PR-URL: #30964 Refs: #29529 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.
PR-URL: #30964
Refs: #29529
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes