repl: fix preview cursor position #31293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cusor position was off in case the preview was exactly as long as the current terminal was wide. Fixes: nodejs#31291
ZYSzys
approved these changes
Jan 10, 2020
antsmartian
approved these changes
Jan 10, 2020
BridgeAR
added
the
author ready
Trott
approved these changes
Jan 12, 2020
BridgeAR
added a commit
that referenced
this pull request
Jan 12, 2020
The cusor position was off in case the preview was exactly as long as the current terminal was wide. PR-URL: #31293 Fixes: #31291 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in af5ddf2 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
The cusor position was off in case the preview was exactly as long as the current terminal was wide. PR-URL: #31293 Fixes: #31291 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
|
@BridgeAR this will need a manual backport - it's blocked on previous repl changes which haven't been able to land. |
1 similar comment
|
@BridgeAR this will need a manual backport - it's blocked on previous repl changes which haven't been able to land. |
targos
removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
The cusor position was off in case the preview was exactly as long as the current terminal was wide. PR-URL: nodejs#31293 Fixes: nodejs#31291 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
The cusor position was off in case the preview was exactly as long as the current terminal was wide. PR-URL: #31293 Fixes: #31291 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cusor position was off in case the preview was exactly as long
as the current terminal was wide.
To fix the issue this switches the calculation from a relative value to an absolute one.
Fixes: #31291
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes