test: allow disabling crypto tests #31268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
addaleax
approved these changes
Jan 9, 2020
devnexen
approved these changes
Jan 9, 2020
|
With this change, using |
codebytere
force-pushed
the
allow-disabling-crypto-tests
branch
from
325cfa8
to
8835e5f
Compare
|
@Trott It turns out that individual tests are validated in js with the same mechanism, so i've moved this logic into common and added documentation for a new simple env var, cc @addaleax since i've moved this mechanism, this probably needs a re-review |
codebytere
force-pushed
the
allow-disabling-crypto-tests
branch
from
8835e5f
to
ee3d29b
Compare
codebytere
force-pushed
the
allow-disabling-crypto-tests
branch
from
ee3d29b
to
c8cf0fd
Compare
addaleax
approved these changes
Jan 9, 2020
richardlau
approved these changes
Jan 9, 2020
codebytere
changed the title
codebytere
force-pushed
the
allow-disabling-crypto-tests
branch
from
c8cf0fd
to
55d796d
Compare
BridgeAR
approved these changes
Jan 9, 2020
|
Marking as author ready without CI, since it should not have any effect. |
BridgeAR
added
the
author ready
Trott
approved these changes
Jan 10, 2020
I'd still suggest running CI to make sure, for example, ubuntu1804_sharedlibs_withoutssl_x64 still works. |
cjihrig
approved these changes
Jan 10, 2020
tniessen
approved these changes
Jan 10, 2020
jasnell
approved these changes
Jan 10, 2020
devnexen
approved these changes
Jan 10, 2020
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 11, 2020
PR-URL: nodejs#31268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in be055d1 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
codebytere
added a commit
that referenced
this pull request
Mar 14, 2020
PR-URL: #31268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
codebytere
added a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new environment variable to the test suit:
NODE_SKIP_CRYPTO. Right now whether or not crypto tests can be run is solely determined by whether or notopensslis defined on theprocessobject, which is true for Electron.js since many consumers use it to determine the presence of crypto even though we use BoringSSL and thus experience incompatibilities.This new option would allow us to more effectively run our own smoke tests of Node.js' test suite without needing to manually disable every crypto test individually.
cc @tniessen
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes