docs: fix stream async iterator sample #31252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
ronag
force-pushed
the
doc-async-iterator-write
branch
2 times, most recently
from
701e364
to
ad5e164
Compare
ronag
commented
Jan 7, 2020
ronag
force-pushed
the
doc-async-iterator-write
branch
4 times, most recently
from
02a4a94
to
542711c
Compare
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: nodejs#31222
ronag
force-pushed
the
doc-async-iterator-write
branch
from
542711c
to
a778098
Compare
ronag
force-pushed
the
doc-async-iterator-write
branch
from
cfe161a
to
f1d486a
Compare
ronag
commented
Jan 7, 2020
| // Handle backpressure on write(). | ||
| if (!writable.write(chunk)) | ||
| if (!writable.write(chunk)) { | ||
| if (writable.destroyed) return; |
There was a problem hiding this comment.
This writable.destroyed check is ugly but I don't see a way around it...
Trott
approved these changes
Jan 10, 2020
Trott
added
the
author ready
jasnell
approved these changes
Jan 10, 2020
Trott
pushed a commit
that referenced
this pull request
Jan 10, 2020
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: #31222 PR-URL: #31252 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott
pushed a commit
that referenced
this pull request
Jan 10, 2020
PR-URL: #31252 Fixes: #31222 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in e468759...5f76f76. Thanks for using |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: #31222 PR-URL: #31252 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31252 Fixes: #31222 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: #31222 PR-URL: #31252 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
PR-URL: #31252 Fixes: #31222 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: #31222 PR-URL: #31252 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31252 Fixes: #31222 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The for await loop into writable could cause an unhandled exception
in the case where we are waiting for data from the async iterable and
there is no
'error'handler registered on the writable.Fixes: #31222
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes