From 3da691b30bb385c511aa3985b2436830c3fc0672 Mon Sep 17 00:00:00 2001
From: Harshitha KP <harshi46@in.ibm.com>
Date: Mon, 6 Jan 2020 00:52:14 -0500
Subject: [PATCH 1/4] doc: explain native external types

There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: https://github.com/nodejs/node/pull/31173#discussion_r362816411
---
 doc/api/util.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/api/util.md b/doc/api/util.md
index 6a6eaf65e7ef50..6f120c33a46fe8 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -1392,6 +1392,9 @@ added: v10.0.0
 * Returns: {boolean}
 
 Returns `true` if the value is a native `External` value.
+`native external` is data that is:
+i) not stored inside JS heap
+ii) not conformant to JS types
 
 ### `util.types.isFloat32Array(value)`
 <!-- YAML

From ccb8109ea4c4efc3e07bd200bb2b568f8bca63f9 Mon Sep 17 00:00:00 2001
From: Harshitha KP <harshi46@in.ibm.com>
Date: Tue, 7 Jan 2020 09:37:19 -0500
Subject: [PATCH 2/4] fixup: address review comment

---
 doc/api/util.md | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/api/util.md b/doc/api/util.md
index 6f120c33a46fe8..dd6d6a549a9f2f 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -1391,10 +1391,11 @@ added: v10.0.0
 * `value` {any}
 * Returns: {boolean}
 
-Returns `true` if the value is a native `External` value.
-`native external` is data that is:
-i) not stored inside JS heap
-ii) not conformant to JS types
+A native `External` value is a special type of object whose
+data is (a) not stored within the JavaScript managed heap
+and (b) does not conform to standard JavaScript types. Such
+objects are created either by Node.js internals or native
+addons and are wrapped by a JavaScript object.
 
 ### `util.types.isFloat32Array(value)`
 <!-- YAML

From c9a6beae757b0e5ea7ebaedf3218bed341fc1f88 Mon Sep 17 00:00:00 2001
From: Harshitha KP <harshi46@in.ibm.com>
Date: Tue, 7 Jan 2020 23:49:38 -0500
Subject: [PATCH 3/4] fixup: address review comments

---
 doc/api/util.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/api/util.md b/doc/api/util.md
index dd6d6a549a9f2f..03a3bbff106817 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -1392,8 +1392,8 @@ added: v10.0.0
 * Returns: {boolean}
 
 A native `External` value is a special type of object whose
-data is (a) not stored within the JavaScript managed heap
-and (b) does not conform to standard JavaScript types. Such
+data is not stored within the JavaScript managed heap
+and does not conform to standard JavaScript types. Such
 objects are created either by Node.js internals or native
 addons and are wrapped by a JavaScript object.
 

From 454be736b4ebd91718eb988665149944ae729abb Mon Sep 17 00:00:00 2001
From: Harshitha KP <harshi46@in.ibm.com>
Date: Wed, 8 Jan 2020 00:41:29 -0500
Subject: [PATCH 4/4] fixup: add back removed line.

---
 doc/api/util.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/api/util.md b/doc/api/util.md
index 03a3bbff106817..469bcf2b6455e9 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -1391,6 +1391,7 @@ added: v10.0.0
 * `value` {any}
 * Returns: {boolean}
 
+Returns `true` if the value is a native `External` value.
 A native `External` value is a special type of object whose
 data is not stored within the JavaScript managed heap
 and does not conform to standard JavaScript types. Such