build: ignore report files generated during tests #30921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on windows I get files like report.20191212.212411.11544.0.001.json in the root of my repo but I expect they shouldn't be committed.
nodejs-github-bot
added
the
meta
|
I do remember getting those as well before on Linux. This seems like a bug in a test. It should clean up after itself, which it does not seem to do properly. I would rather fix the test though than ignoring these files. |
|
Ah ok, that sounds reasonable. Any hints which tests generate such files? |
|
It's from the newly added |
|
close as real fix is in #30925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on windows I get files like report.20191212.212411.11544.0.001.json
in the root of my repo but I expect they shouldn't be committed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes