Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove (almost) unused macros/constants #30755

Closed
wants to merge 3 commits into from
Closed

build: remove (almost) unused macros/constants #30755

wants to merge 3 commits into from

Commits on Dec 5, 2019

  1. build: remove (almost) unused macros/constants 

    Macros, like CHECK, cause issues for tracking coverage because
they modify the source before it's placed in V8. Upon investigation
it seemed that we only used this functionality in two places:
internal/vm/module.js, and internal/async_hooks.js (in comments).

Given this, it seemed to make more sense to move CHECK to
JavaScript, and retire a mostly unused build step.
    @bcoe
    bcoe committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    6db1a08 View commit details
    Browse the repository at this point in the history

  2. chore: address code review

    @bcoe
    bcoe committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    3765e06 View commit details
    Browse the repository at this point in the history

  3. chore: switch to assert

    @bcoe
    bcoe committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    2530062 View commit details
    Browse the repository at this point in the history