doc: add mention for using promisify on class methods #30355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
devsnek
reviewed
Nov 10, 2019
Trott
reviewed
Nov 10, 2019
jasnell
approved these changes
Nov 12, 2019
BridgeAR
approved these changes
Nov 13, 2019
BridgeAR
added
the
author ready
trivikr
pushed a commit
that referenced
this pull request
Nov 21, 2019
Fixes: #30344 PR-URL: #30355 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 8138e9c |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2019
Fixes: #30344 PR-URL: #30355 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Fixes: #30344 PR-URL: #30355 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Fixes: #30344 PR-URL: #30355 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30344
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes