Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: fix .format() not always calling toString when it should be #30343

Closed
wants to merge 2 commits into from
Closed

util: fix .format() not always calling toString when it should be #30343

wants to merge 2 commits into from

Commits on Nov 26, 2019

  1. util: fix .format() not always calling toString when it should be 

    This makes sure that `util.format('%s', object)` will always call
a user defined `toString` function. It was formerly not the case
when the object had the function declared on the super class.

At the same time this also makes sure that getters won't be
triggered accessing the `constructor` property.
    @BridgeAR
    BridgeAR committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    cde7fde View commit details
    Browse the repository at this point in the history

  2. fixup

    @BridgeAR
    BridgeAR committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    2f48041 View commit details
    Browse the repository at this point in the history