Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix Python 3 syntax error in mac_tool.py #30146

Closed
wants to merge 1 commit into from
Closed

tools: fix Python 3 syntax error in mac_tool.py #30146

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 27, 2019

Discovered at #30129 (comment)
Confirmed in #30143

  File "./gyp-mac-tool", line 673
    max_value_length = len(max(filelist.items(), key=lambda (k,v):len(v))[1])
                                                            ^
SyntaxError: invalid syntax

https://portingguide.readthedocs.io/en/latest/syntax.html#tuple-unpacking-in-parameter-lists

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Oct 27, 2019
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Oct 27, 2019
bnoordhuis
bnoordhuis reviewed Oct 27, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're making several changes. Can you split them into separate commits?

@cclauss cclauss requested a review from targos October 27, 2019 13:48
@chrmoritz
Copy link

I think this would still need a backport of nodejs/node-gyp@a48f09b#diff-a486ea7ed25fd07c6c5a3aee31ed8308 to make it fully compatible with Python 3.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 27, 2019 •
edited
Loading

@chrmoritz nodejs/node-gyp#1937 contains those changes and was already merged.

You need to wait on the second gyp round trip which is blocked until nodejs/node-gyp#1935 lands and then is picked up by npm/cli and then reimported into nodejs/node /tools.

Vendoring in dependencies is awesome. NOT!!

This was referenced Oct 27, 2019
Closed
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26263/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26272/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26273/

cclauss added a commit that referenced this pull request Nov 1, 2019
@cclauss
tools: fix Python 3 syntax error in mac_tool.py
9529c66 
PR-URL: #30146
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@cclauss
Copy link
Contributor Author

cclauss commented Nov 1, 2019

Landed in 9529c66

@cclauss cclauss closed this Nov 1, 2019
@cclauss cclauss deleted the fix-tools-mac_tool.py branch November 1, 2019 08:04
targos pushed a commit that referenced this pull request Nov 5, 2019
@cclauss @targos
tools: fix Python 3 syntax error in mac_tool.py
348ec69 
PR-URL: #30146
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@cclauss @targos
tools: fix Python 3 syntax error in mac_tool.py
b2e0f46 
PR-URL: #30146
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: David Carlier <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss @targos
tools: fix Python 3 syntax error in mac_tool.py
502b1e1 
PR-URL: #30146
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: David Carlier <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss @targos
tools: fix Python 3 syntax error in mac_tool.py
922f8d7 
PR-URL: #30146
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@cclauss @targos
tools: fix Python 3 syntax error in mac_tool.py
b654673 
PR-URL: #30146
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis left review comments

@devnexen devnexen devnexen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@codebytere codebytere codebytere approved these changes

@sam-github sam-github Awaiting requested review from sam-github

@rvagg rvagg Awaiting requested review from rvagg

@Trott Trott Awaiting requested review from Trott

@richardlau richardlau Awaiting requested review from richardlau

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cclauss @chrmoritz @nodejs-github-bot @bnoordhuis @codebytere @gengjiawen @devnexen