http,https: increase server headers timeout #30071
Conversation
nodejs-github-bot
added
http
addaleax
added
the
author ready
|
Also @nodejs/security since the original introduction of this feature was in a security release |
There was a problem hiding this comment.
Seems like a reasonable change to me. But.
I remember thinking at the time that 40 seconds was a good default because lots of load balancers and reverse proxies probably operate with 30 second timeouts (because that's how people work, they're attracted to Schelling points.)
Perhaps then it's a good idea to set the timeout to just over 60 seconds, e.g., 65?
Trott
added
the
notable-change
|
Landed in e17403e |
Fixes: #24980 Refs: eb43bc04b1 PR-URL: #30071 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #24980 Refs: eb43bc04b1 PR-URL: #30071 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Notable Changes:
* cli:
* add --trace-exit cli option (legendecas)
#30516
* http,https:
* increase server headers timeout (Tim Costa)
#30071
* readline:
* update ansi-regex (Ruben Bridgewater)
#30907
* promote \_getCursorPos to public api (Jeremy Albright)
#30687
* repl:
* add completion preview (Ruben Bridgewater)
#30907
* util:
* add Set and map size to inspect output (Ruben Bridgewater)
#30225
* wasi:
* require CLI flag to require() wasi module (Colin Ihrig)
#30963
PR-URL: #31010
Notable Changes:
* cli:
* add --trace-exit cli option (legendecas)
#30516
* http,https:
* increase server headers timeout (Tim Costa)
#30071
* readline:
* update ansi-regex (Ruben Bridgewater)
#30907
* promote \_getCursorPos to public api (Jeremy Albright)
#30687
* repl:
* add completion preview (Ruben Bridgewater)
#30907
* util:
* add Set and map size to inspect output (Ruben Bridgewater)
#30225
* wasi:
* require CLI flag to require() wasi module (Colin Ihrig)
#30963
PR-URL: #31010
|
For compatibility with ELB, not only In order to prevent errors due to the race condition of each other's connection timeout, all the connection timeouts inside the ELB must be greater than ELB's idle timeout. |
|
@Ajido actually no, at least not in the context of this PR. This PR handles the fact that the AWS ELBs pre-warm TCP connections to the backing servers. This is not a connection that is subject to keep-alive until later on the connection lifecycle. The |
targos
added
baking-for-lts
|
This is an interesting issue, thought I might summarize it. The ‘headerstimeout’ was added to prevent a Slowloris kind of attack where an attacker can max out the server’s connections by slowly sending few bytes of the headers at an interval thus keeping the connection “active” and drain resources. The default for ‘headerstimeout’ was set to 40s when this was first implemented. Clients that prewarms or pool connections (e.g. reverse proxies) Might get an error if their client idle timeout is greater than the ’headerstimeout’. The connection will be terminated as a result after the default 40s elapses with no client activity. Increasing the ‘headerstimeout’ to 60s seems like a good default. However, users might still run into this bug if their reverse proxy uses a higher idle timeout (> 60s) to communicate with a node js backend. It is important to mention that this problem is specific for clients that pre-warms connections, specially layer 7 proxies. Layer 4 streaming proxies should not run into this bug. |
|
@timcosta could you please manually backport this to v12.x? |
MylesBorins
removed
the
baking-for-lts
|
This now lands cleanly on v12.x. I'll include it in the next minor. |
Fixes: nodejs#24980 Refs: nodejs@eb43bc04b1 PR-URL: nodejs#30071 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
removed
the
author ready
Fixes: #24980 Refs: eb43bc04b1 PR-URL: #30071 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #24980
Refs: eb43bc04b1
Increases the default server headers timeout from 40 seconds to 60 seconds in order to not break compatibility with AWS ELBs in the default configuration.
Over the last several months, I have helped no fewer than 20 different groups of people in Slack teams resolve this issue. I believe that this is worth of a change even though it was originally a security fix because this change keeps intact the intended fix, but restores compatibility in the default configuration with any load balancer that prewarms TCP connections and holds them for over 40 seconds, just like AWS ELBs do.
Node in its default configuration should not be broken with AWS ELBs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes