Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add server header into the discarded list of message.headers #29962

Closed
wants to merge 1 commit into from
Closed

doc: add server header into the discarded list of message.headers #29962

wants to merge 1 commit into from

Conversation

Huachao
Copy link
Contributor

@Huachao Huachao commented Oct 14, 2019

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Oct 14, 2019
@Trott
Copy link
Member

Trott commented Oct 14, 2019

@nodejs/http

@trivikr trivikr added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 16, 2019
@trivikr
Copy link
Member

trivikr commented Oct 16, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3994/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2019
Trott pushed a commit that referenced this pull request Oct 16, 2019
@Huachao @Trott
doc: add server header into the discarded list of http message.headers
405a280 
PR-URL: #29962
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 16, 2019

Landed in 405a280

@Trott Trott closed this Oct 16, 2019
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@Huachao @MylesBorins
doc: add server header into the discarded list of http message.headers
828e171 
PR-URL: #29962
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@Huachao @targos
doc: add server header into the discarded list of http message.headers
eadd490 
PR-URL: #29962
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@Huachao @targos
doc: add server header into the discarded list of http message.headers
c0cbfae 
PR-URL: #29962
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Nov 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Huachao @Trott @trivikr @jasnell @nodejs-github-bot