Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http2-client-upload #29889

Closed
wants to merge 2 commits into from
Closed

test: fix flaky test-http2-client-upload #29889

wants to merge 2 commits into from

Commits on Dec 18, 2019

  1. test: fix flaky test-http2-client-upload 

    Wait for close event on server stream before shuting down server and
client to avoid races seen on windows CI.

Refs: nodejs#20750 (comment)
    @Flarna
    Flarna committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    85ab527 View commit details
    Browse the repository at this point in the history

  2. Update test/parallel/test-http2-client-upload.js 

    Co-Authored-By: Anna Henningsen <[email protected]>
    @Flarna @addaleax
    Flarna and addaleax committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    10189a5 View commit details
    Browse the repository at this point in the history