deps: update npm to 6.12.0 #29885
Closed
deps: update npm to 6.12.0 #29885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
npm
63 tasks
sam-github
approved these changes
Oct 8, 2019
|
@nodejs/npm I kicked off normal PR CI, but don't know if any extra is required for npm. PTAL |
Trott
added
the
author ready
gengjiawen
approved these changes
Oct 9, 2019
3 tasks
|
According to policy, this can land on October 22. However, that's also the day of the Node.js 13.0.0 release. I'd really like to see this in that release, so I'd like to propose shortening the npm-merge wait-period to 1 week for this, which means that it can land on October 15. Thoughts on this, @nodejs/tsc, @nodejs/releasers, and especially @BethGriggs who is doing the release? (The Release WG is solely responsible for determining the contents of any release, but they usually ask/defer to the TSC on controversial things, so tagging both.) |
3 tasks
Trott
added
the
notable-change
BethGriggs
approved these changes
Oct 11, 2019
|
I'm +1 on this landing ~15th October so it can make it into the final release candidate of v13.0.0 |
|
+1
Il giorno ven 11 ott 2019 alle 14:57 Bethany Nicolle Griggs <
[email protected]> ha scritto:
… I'm +1 on this landing ~15th October so it can make it into the final
release candidate of v13.0.0
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#29885?email_source=notifications&email_token=AAAMXY4MPLUJDK2LI6I2UA3QOBZ2VA5CNFSM4I6TWZJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA742UI#issuecomment-541052241>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMXY7ICU6W5MXA7A6NXCLQOBZ2VANCNFSM4I6TWZJQ>
.
|
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 12, 2019
The two-week wait period for merging npm releases is one of those rule exceptions that would be great to get rid of (in my opinion at least). There are too many exceptions to our rules and they tend to be scattered across multiple documents. People don't feel confident they know the rules, thus hampering both project velocity and Collaborator confidence. It also means I (and perhaps others?) get lots of pings about whether this or that can land, etc. This particular issue has come up a few times lately, and is specifically calling for an exception-to-the-exception so that the latest version of npm can be released along with Node.js 13.0.0. Refs: nodejs#29885 (comment) I propose here reducing the wait period from two weeks to one week. If, after some amount of time, there seems to be no problems caused by this change, we can consider further reducing the wait period to 48 hours to align it with all other change requests. Even if you think that is going too far, hopefully we can at least get it reduced to a week, as the second week of the waiting period is usually just the PR sitting around with an occasional ping from someone about whether/when it can land. PR-URL: nodejs#29922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 15, 2019
Update npm to 6.12.0 Now `npm ci` runs prepare scripts for git dependencies, and respects the `--no-optional` argument. Warnings for `engine` mismatches are printed again. Various other fixes and cleanups. PR-URL: nodejs#29885 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Christian Clauss <[email protected]>
|
Landed in 3ebaf6b |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update npm to 6.12.0. Release notes:
6.12.0 (2019-10-08):
Now
npm ciruns prepare scripts for git dependencies, and respects the--no-optionalargument. Warnings forenginemismatches are printed again. Various other fixes and cleanups.BUG FIXES
890b245dc#252 ci: add dirPacker to options (@claudiahdz)f3299acd0#257 npm.community#4792 warn message on engine mismatch (@ruyadorno)bbc92fb8f#259 npm.community#10288 Fix figgyPudding error innpm token(@benblank)70f54dcb5#241 doctor: Make OK more consistent (@gemal)FEATURES
ed993a29c#249 Add CI environment variables to user-agent (@isaacs)f6b0459a4#248 Add option to save package-lock without formatting Adds a new config--format-package-lock, which defaults to true. (@bl00mber)DEPENDENCIES
0ca063c5d[email protected]:5df6b0ea2[email protected]:7e04f728c[email protected]5c380e5a3[email protected](@isaacs)62f2ca692[email protected](@isaacs)0ff0ea47a[email protected](@isaacs)f46edae94[email protected](@isaacs)TESTING
44a2b036b#262 fix root-ownership race conditions in meta-test (@isaacs)