Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: add Synthetic modules #29864

Closed
wants to merge 1 commit into from
Closed

vm: add Synthetic modules #29864

wants to merge 1 commit into from

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Oct 6, 2019

  • Refactor vm.SourceTextModule (again)
  • Add vm.Module abstract superclass
  • Add vm.SyntheticModule

Refs: https://heycam.github.io/webidl/#synthetic-module-records

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@devsnek devsnek added vm Issues and PRs related to the vm subsystem. experimental Issues and PRs related to experimental features. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 6, 2019
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 6, 2019
@devsnek
Copy link
Member Author

devsnek commented Oct 6, 2019

cc @vsemozhetbyt

@devsnek devsnek removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 6, 2019
@devsnek devsnek force-pushed the more-vm-shenanigans branch 3 times, most recently from c396c6e to 20ee326 Compare October 7, 2019 19:07
vsemozhetbyt
vsemozhetbyt reviewed Oct 7, 2019
View reviewed changes
tools/doc/type-parser.js Show resolved Hide resolved
doc/api/vm.md Outdated Show resolved Hide resolved
doc/api/vm.md Outdated Show resolved Hide resolved
guybedford
guybedford approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

test/parallel/test-vm-module-synthetic.js Outdated Show resolved Hide resolved
src/module_wrap.cc Show resolved Hide resolved
src/module_wrap.cc Outdated Show resolved Hide resolved
addaleax
addaleax reviewed Oct 7, 2019
View reviewed changes
src/node_util.cc Outdated Show resolved Hide resolved
targos
targos reviewed Oct 8, 2019
View reviewed changes
doc/api/vm.md Outdated Show resolved Hide resolved
targos
targos reviewed Oct 8, 2019
View reviewed changes
doc/api/vm.md
added: REPLACEME
-->

* `name` {string} Name of the export to set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if name was not listed in exportNames?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spec says a ReferenceError is thrown but V8 currently aborts. I posted about it on the bug tracker yesterday so hopefully it will be fixed soon.

@devsnek devsnek force-pushed the more-vm-shenanigans branch 3 times, most recently from 3b8872d to 380891b Compare October 12, 2019 07:11
@devsnek
vm: add Synthetic modules
baf46f6 
- Refactor vm.SourceTextModule (again)
- Add vm.Module abstract superclass
- Add vm.SyntheticModule

Refs: https://heycam.github.io/webidl/#synthetic-module-records
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25988/

@Trott
Copy link
Member

Trott commented Oct 13, 2019

@nodejs/vm

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 13, 2019
Trott pushed a commit that referenced this pull request Oct 14, 2019
@devsnek @Trott
vm: add Synthetic modules
f9caee9 
- Refactor vm.SourceTextModule (again)
- Add vm.Module abstract superclass
- Add vm.SyntheticModule

Refs: https://heycam.github.io/webidl/#synthetic-module-records

PR-URL: #29864
Reviewed-By: Guy Bedford <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 14, 2019

Landed in f9caee9

@Trott Trott closed this Oct 14, 2019
@devsnek devsnek deleted the more-vm-shenanigans branch October 14, 2019 21:51
@molllyn1 molllyn1 mentioned this pull request Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@baby636 baby636 mentioned this pull request Nov 5, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Nov 5, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 5, 2022
Open
@kissofire kissofire mentioned this pull request Nov 5, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 25, 2022
Open
@kissofire kissofire mentioned this pull request Dec 25, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Dec 26, 2022
Open
@137717unity 137717unity mentioned this pull request Dec 26, 2022
Open
@baby636 baby636 mentioned this pull request Dec 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Oct 1, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
@kissofire kissofire mentioned this pull request Oct 1, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 2, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Oct 2, 2023
Open
@137717unity 137717unity mentioned this pull request Oct 2, 2023
Open
@baby636 baby636 mentioned this pull request Oct 2, 2023
Open
@baby636 baby636 mentioned this pull request Jan 2, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Jan 9, 2024
Open
@kissofire kissofire mentioned this pull request Jan 9, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Jan 9, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Jan 9, 2024
Open
@137717unity 137717unity mentioned this pull request Jan 9, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 9, 2024
Open
@baby636 baby636 mentioned this pull request Jan 9, 2024
Open
@baby636 baby636 mentioned this pull request Mar 19, 2024
Open
@baby636 baby636 mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@Jamesernator Jamesernator Jamesernator left review comments

@targos targos targos left review comments

@addaleax addaleax addaleax left review comments

@guybedford guybedford guybedford approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. experimental Issues and PRs related to experimental features. semver-minor PRs that contain new features and should be released in the next minor version. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@devsnek @nodejs-github-bot @Trott @guybedford @addaleax @targos @joyeecheung @Jamesernator @vsemozhetbyt