-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8 Synthetic Modules Implementation #29846
Conversation
Relevant commit for review - cb2654c |
cb2654c
to
fbb4715
Compare
i'm pretty sure that REPLACEME is supposed to be a REPLACEME |
@devsnek you mean in that it's intended to be left in or replaced!? |
@guybedford you replaced an example showing how to add a new method to the docs. |
7d805f9
to
f5038a7
Compare
Ok I've rebased to the correct fix for the REPLACEME from #29737. |
f5038a7
to
2fed602
Compare
@guybedford what's up with that |
@devsnek no Node master is fine actually. It was just a bug fix on this PR. |
@guybedford oh cool, just wanted to make sure it wasn't going in as a separate commit :) (for future reference, you can prefix commits with |
@Trott are we good to merge this later today? Or do we still do 72 hours for weekends? (I couldn't find reference to this in the collaborating guide anymore though) |
according to NCU this needs to wait one more hour |
PR-URL: #29846 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Landed in ffd22e8. |
@guybedford Yes, we got rid of the 72-hour rule. It's always 48 hours now. |
PR-URL: #29846 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
This updates uses of
createDynamicModule
to instead use a newModuleWrap
signature for creating v8 Synthetic Module Records instead.We still need to retain
createDynamicModule
for WASM due to imports and for the dynamic loader due to the exact behaviours, but these uses will likely be phased out over time anyway.This PR is based on top of #29737, so should merge after that. This is also prerequisite to the unflagging, as discussed in nodejs/modules#394.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes