From 211b0cb8c846d77456af9e9a94458165a5cc1a6b Mon Sep 17 00:00:00 2001 From: TATSUNO Yasuhiro Date: Mon, 23 Sep 2019 19:25:15 +0900 Subject: [PATCH 1/3] doc: fix type of atime/mtime --- doc/api/fs.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index 8aa2d6d8c04e1a..e9cf70c78b75d1 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2086,8 +2086,8 @@ changes: --> * `fd` {integer} -* `atime` {integer} -* `mtime` {integer} +* `atime` {number|string|Date} +* `mtime` {number|string|Date} Synchronous version of [`fs.futimes()`][]. Returns `undefined`. @@ -3462,8 +3462,8 @@ changes: --> * `path` {string|Buffer|URL} -* `atime` {integer} -* `mtime` {integer} +* `atime` {number|string|Date} +* `mtime` {number|string|Date} Returns `undefined`. From 019b62801f71157fcf589c1e8f9a978fc5674793 Mon Sep 17 00:00:00 2001 From: exoego Date: Tue, 24 Sep 2019 06:22:06 +0900 Subject: [PATCH 2/3] doc: fix wrong numeric type --- doc/api/fs.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index e9cf70c78b75d1..1f6699ba4ca6bf 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2064,8 +2064,8 @@ changes: --> * `fd` {integer} -* `atime` {number|string|Date} -* `mtime` {number|string|Date} +* `atime` {integer|string|Date} +* `mtime` {integer|string|Date} * `callback` {Function} * `err` {Error} @@ -2086,8 +2086,8 @@ changes: --> * `fd` {integer} -* `atime` {number|string|Date} -* `mtime` {number|string|Date} +* `atime` {integer|string|Date} +* `mtime` {integer|string|Date} Synchronous version of [`fs.futimes()`][]. Returns `undefined`. @@ -3429,8 +3429,8 @@ changes: --> * `path` {string|Buffer|URL} -* `atime` {number|string|Date} -* `mtime` {number|string|Date} +* `atime` {integer|string|Date} +* `mtime` {integer|string|Date} * `callback` {Function} * `err` {Error} @@ -3462,8 +3462,8 @@ changes: --> * `path` {string|Buffer|URL} -* `atime` {number|string|Date} -* `mtime` {number|string|Date} +* `atime` {integer|string|Date} +* `mtime` {integer|string|Date} Returns `undefined`. @@ -4233,8 +4233,8 @@ The last three bytes are null bytes (`'\0'`), to compensate the over-truncation. added: v10.0.0 --> -* `atime` {number|string|Date} -* `mtime` {number|string|Date} +* `atime` {integer|string|Date} +* `mtime` {integer|string|Date} * Returns: {Promise} Change the file system timestamps of the object referenced by the `FileHandle` @@ -4839,8 +4839,8 @@ added: v10.0.0 --> * `path` {string|Buffer|URL} -* `atime` {number|string|Date} -* `mtime` {number|string|Date} +* `atime` {integer|string|Date} +* `mtime` {integer|string|Date} * Returns: {Promise} Change the file system timestamps of the object referenced by `path` then From 22157efea1c15b2078da9667fbddf1d8b6540b9c Mon Sep 17 00:00:00 2001 From: exoego Date: Sat, 28 Sep 2019 12:01:43 +0900 Subject: [PATCH 3/3] doc: use number since there are no rounding nor validation --- doc/api/fs.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index 1f6699ba4ca6bf..e9cf70c78b75d1 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2064,8 +2064,8 @@ changes: --> * `fd` {integer} -* `atime` {integer|string|Date} -* `mtime` {integer|string|Date} +* `atime` {number|string|Date} +* `mtime` {number|string|Date} * `callback` {Function} * `err` {Error} @@ -2086,8 +2086,8 @@ changes: --> * `fd` {integer} -* `atime` {integer|string|Date} -* `mtime` {integer|string|Date} +* `atime` {number|string|Date} +* `mtime` {number|string|Date} Synchronous version of [`fs.futimes()`][]. Returns `undefined`. @@ -3429,8 +3429,8 @@ changes: --> * `path` {string|Buffer|URL} -* `atime` {integer|string|Date} -* `mtime` {integer|string|Date} +* `atime` {number|string|Date} +* `mtime` {number|string|Date} * `callback` {Function} * `err` {Error} @@ -3462,8 +3462,8 @@ changes: --> * `path` {string|Buffer|URL} -* `atime` {integer|string|Date} -* `mtime` {integer|string|Date} +* `atime` {number|string|Date} +* `mtime` {number|string|Date} Returns `undefined`. @@ -4233,8 +4233,8 @@ The last three bytes are null bytes (`'\0'`), to compensate the over-truncation. added: v10.0.0 --> -* `atime` {integer|string|Date} -* `mtime` {integer|string|Date} +* `atime` {number|string|Date} +* `mtime` {number|string|Date} * Returns: {Promise} Change the file system timestamps of the object referenced by the `FileHandle` @@ -4839,8 +4839,8 @@ added: v10.0.0 --> * `path` {string|Buffer|URL} -* `atime` {integer|string|Date} -* `mtime` {integer|string|Date} +* `atime` {number|string|Date} +* `mtime` {number|string|Date} * Returns: {Promise} Change the file system timestamps of the object referenced by `path` then