deps: update V8 to 7.8 #29493

ryzokuken · 2019-09-08T16:31:54Z

ETA: Oct 22nd, 2019

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: nodejs#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. [email protected],[email protected],[email protected] CC=[email protected] Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Michael Starzinger <[email protected]> Commit-Queue: Tamer Tas <[email protected]> Cr-Commit-Position: refs/heads/master@{#59045} Refs: v8/v8@bd019bd PR-URL: nodejs#26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

PR-URL: nodejs#26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

Fixes a compilation issue on some platforms PR-URL: nodejs#27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

This should be semver-patch since actual invocation is version conditional. PR-URL: nodejs#27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

`std::atomic_init<size_t>` is not implemented on all platforms. PR-URL: nodejs#27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: nodejs#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

PR-URL: nodejs#27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: nodejs#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

until c6196ad7a2d601a4e1fdb313bfe2ec727fd67f7a Co-authored-by: Ujjwal Sharma <[email protected]> Co-authored-by: Michaël Zasso <[email protected]>

targos · 2019-09-08T16:40:11Z

We need to find a better message for the last commit 😅

nodejs-github-bot · 2019-09-08T16:52:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25397/

gengjiawen · 2019-09-11T00:02:08Z

on macOS: https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1011/28796/console

00:57:40 ../deps/v8/src/compiler/js-heap-broker.cc:4116:23: error: constructor for 'v8::internal::compiler::GlobalAccessFeedback' must explicitly initialize the const member 'cell_or_context_'
00:57:40 GlobalAccessFeedback::GlobalAccessFeedback(FeedbackSlotKind slot_kind)
00:57:40                       ^
00:57:40 ../deps/v8/src/compiler/processed-feedback.h:83:35: note: 'cell_or_context_' declared here
00:57:40   base::Optional<ObjectRef> const cell_or_context_;

ryzokuken · 2019-09-11T16:24:34Z

@gengjiawen http://logs.libuv.org/node-build/2019-09-11#16:20:08.434

rvagg · 2019-09-11T23:28:05Z

I think we might be a bit stuck on this one. In BUILDING.md we have Xcode 8 as our minimum. That machine has 8 on it ("version: 8.2.0.0.1.1480973914"). If this isn't going to compile there then I think there are two obvious choices (maybe there's non-obvious ones?):

Mark this semver-major and change our BUILDING.md support matrix to match the new minimum required by this. Will need @nodejs/build buy-in but I don't imagine it'll be too controversial.
Work on fixing the code to compile with the current compiler. It might not be too hard to do, there may even be just that one place with a problem. Getting a local config with Xcode 8 might be the trickier bit but maybe we can give you access to a build machine to do it on? Open an issue in nodejs/build requesting ssh access to a specific type of machine and we should be able to organise that if you want to try it.

bnoordhuis · 2019-09-12T09:57:04Z

Is it even reasonable to support xcode 8? If you submit a bug report to Apple, it's not like they're going to fix it, they'll just tell you to upgrade to xcode 10.

(In reality, they're not going to tell you anything because Apple but you know what I mean.)

gengjiawen · 2019-09-12T10:09:19Z

Is it even reasonable to support xcode 8? If you submit a bug report to Apple, it's not like they're going to fix it, they'll just tell you to upgrade to xcode 10.

(In reality, they're not going to tell you anything because Apple but you know what I mean.)

Let's set Xcode requirement to 10 ?

ryzokuken · 2019-09-12T10:48:27Z

@bnoordhuis

Is it even reasonable to support xcode 8? If you submit a bug report to Apple, it's not like they're going to fix it, they'll just tell you to upgrade to xcode 10.

Exactly.

(In reality, they're not going to tell you anything because Apple but you know what I mean.)

🤷‍♂ Didn't want to say it out loud, but...

@rvagg

Mark this semver-major and change our BUILDING.md support matrix to match the new minimum required by this. Will need @nodejs/build buy-in but I don't imagine it'll be too controversial.

I think I'd personally prefer this, since me and @targos originally decided to do this also, and IIRC, V8 7.8 isn't going to land on older release lines anyway.

mmarchini · 2019-09-12T14:15:48Z

From our BUILDING.md:

Node.js does not support a platform version if a vendor has expired support for it. In other words, Node.js does not support running on End-of-Life (EoL) platforms. This is true regardless of entries in the table below.

Is xcode still supported by Apple? If it's not, according to our BUILDING.md we don't officially support it either.

(If Apple doesn't support xcode 8 anymore but we do, we should change that paragraph as well as the table)

mhdawson · 2019-09-12T14:51:06Z

Mark this semver-major and change our BUILDING.md support matrix to match the new minimum required by this. Will need @nodejs/build buy-in but I don't imagine it'll be too controversial.

+1 from me but the additional work/thing to figure out is how we continue to test with the older xcode for earlier releases (which I assume we need to given that we would be saying this is SemVer major). It might be time to also update the version we build on (ie start building on 10.12 with an updated xcode version and leave the existing machines as is).

Given that we are 10 days from the SemVer cutoff for 13.x we might have to wait until 14.x (ie do in master after 13.x is cut) as it could take some time to agree/get all of the required pieces in place.

sam-github · 2019-09-17T14:58:14Z

As I understand the current situation, unless someone steps up to do the OS X infrastructure work, it looks like V8 7.8 may not make it into 13.x? If so, that should be called out in the TSC agenda, @nodejs/tsc EDIT: remove the label if I misunderstood!

Trott · 2019-09-17T23:07:40Z

As I understand the current situation, unless someone steps up to do the OS X infrastructure work, it looks like V8 7.8 may not make it into 13.x? If so, that should be called out in the TSC agenda, @nodejs/tsc EDIT: remove the label if I misunderstood!

@sam-github Do you mean merely as an informational item? Or is there an action/decision the TSC needs to take here?

sam-github · 2019-09-18T05:12:41Z

@Trott I think (just my thoughts), that if a deadline is likely to be missed, the TSC should be aware of it. If no one is concerned enough, or able, to do anything about it, that's OK, just so long as its not a surprise.

mhdawson · 2019-09-18T21:06:08Z

We discussed in the TSC meeting:

Myles will follow up with V8 team to see if there is any chance to get a patch so that we can still
land in 13.x before the SemVer major cutoff

There was also the suggestion that we update the minimum for 13.x even though we won't be able to test/build with the newer xcode until later.

@nodejs/build I think updating the minimum now makes sense, it gives us greater flexibility in 13.x and is what we'd want to do, we just can actually do it in time to build/test with it. Please let me know if you agree or not. Otherwise I'll submit a PR to make that change, I'm assuming we'd want to update it to xCode 10 ?

rvagg · 2019-09-18T21:13:08Z

@mhdawsom 👍 let's make the change to 10

mhdawson · 2019-09-19T22:54:14Z

PR to bump minimum xCode version: #29622

gengjiawen · 2019-09-20T09:35:09Z

So is it possible to set build toolchain upgrade as semver-minor. In the end, it won't affect Node.js user, only core devs. Consider V8 7.8 will go to 12.x too ?

rvagg · 2019-09-20T09:42:54Z

In the end, it won't affect Node.js user

A large number of Node.js users compile their own binaries, a large number of intermediates (like package managers) do too. Those are our users for the purpose of semer-major changes to toolchain. Some very large companies have toolchains that take source and compile down to their own binaries using their own rules and if we start breaking toolchain requirements mid-major then we break their pipelines.

Update the minimum Xcode version for macOS to 10. We'll need this level to incorporate future V8 versions. Refs: nodejs#29493

Update the minimum Xcode version for macOS to 10. We'll need this level to incorporate future V8 versions. Refs: #29493 PR-URL: #29622 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>

MylesBorins · 2019-09-24T18:46:36Z

Hey all, I've got an alternative PR that is building on OSX 🎉

@ryzokuken would you be open to closing this in lieu of #29694?

mhdawson · 2019-09-25T12:59:24Z

@sam-github do you think we can remove the tsc-agenda from this one?

ryzokuken · 2019-09-25T13:22:55Z

@MylesBorins would absolutely love to, thanks so much, and sorry I couldn't give enough love to this.

This reverts commit 9f830f3. Ref: nodejs#29622 Ref: nodejs#29493 Node.js build infrastructure is not prepared to release 13.x on anything but Xcode 8 on macOS 10.11.

ryzokuken and others added 14 commits September 8, 2019 21:55

deps: update V8 to 7.8.279.2

c279d62

build: reset embedder string to "-node.0"

937d428

src: update NODE_MODULE_VERSION to 79

781ea59

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

deps: V8: silence irrelevant warning

9a8d072

PR-URL: nodejs#26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

tools: update V8 gypfiles

c19fbb1

until c6196ad7a2d601a4e1fdb313bfe2ec727fd67f7a Co-authored-by: Ujjwal Sharma <[email protected]> Co-authored-by: Michaël Zasso <[email protected]>

assert: fix it

b36a837

ryzokuken self-assigned this Sep 8, 2019

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Sep 8, 2019

ryzokuken requested review from targos and refack September 8, 2019 16:31

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 12, 2019

sam-github added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Sep 17, 2019

sam-github mentioned this pull request Sep 17, 2019

Node.js Foundation Technical Steering Committee (TSC) Meeting 2019-09-18 nodejs/TSC#755

Closed

Trott force-pushed the master branch from 1ecc406 to 49cf67e Compare September 17, 2019 16:50

MylesBorins mentioned this pull request Sep 19, 2019

access for @victorgomes to osx build bot nodejs/build#1920

Closed

mhdawson mentioned this pull request Sep 19, 2019

build: update minimum Xcode version for macos #29622

Closed

3 tasks

mhdawson added a commit to mhdawson/io.js that referenced this pull request Sep 20, 2019

build: update minimum Xcode version for macOS

13ad28f

Update the minimum Xcode version for macOS to 10. We'll need this level to incorporate future V8 versions. Refs: nodejs#29493

Trott mentioned this pull request Sep 23, 2019

Node.js Foundation Technical Steering Committee (TSC) Meeting 2019-09-25 nodejs/TSC#758

Closed

MylesBorins mentioned this pull request Sep 24, 2019

deps: update V8 to 7.8 #29694

Merged

4 tasks

rvagg mentioned this pull request Sep 25, 2019

Inconsistency with OSX build bot nodejs/build#1922

Closed

ryzokuken closed this Sep 25, 2019

mhdawson removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Sep 25, 2019

AshCripps mentioned this pull request Oct 17, 2019

Supporting multiple versions of xcode nodejs/build#1964

Closed

rvagg mentioned this pull request Oct 20, 2019

Revert "build: update minimum Xcode version for macOS" #30043

Closed

sam-github mentioned this pull request Oct 21, 2019

macOS release machine version for Node 12+ nodejs/build#1593

Closed

richardlau mentioned this pull request Nov 15, 2019

Xcode 10 Build Requirement in Node Version 13.1.0 nodejs/help#2297

Closed

sam-github mentioned this pull request Nov 20, 2019

Configuration issues on macOS with Python 3 #30500

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 7.8 #29493

deps: update V8 to 7.8 #29493

ryzokuken commented Sep 8, 2019 •

edited

Loading

targos commented Sep 8, 2019 •

edited

Loading

nodejs-github-bot commented Sep 8, 2019

gengjiawen commented Sep 11, 2019

ryzokuken commented Sep 11, 2019

rvagg commented Sep 11, 2019

bnoordhuis commented Sep 12, 2019

gengjiawen commented Sep 12, 2019

ryzokuken commented Sep 12, 2019

mmarchini commented Sep 12, 2019

mhdawson commented Sep 12, 2019

sam-github commented Sep 17, 2019 •

edited

Loading

Trott commented Sep 17, 2019

sam-github commented Sep 18, 2019

mhdawson commented Sep 18, 2019

rvagg commented Sep 18, 2019

mhdawson commented Sep 19, 2019

gengjiawen commented Sep 20, 2019

rvagg commented Sep 20, 2019

MylesBorins commented Sep 24, 2019

mhdawson commented Sep 25, 2019

ryzokuken commented Sep 25, 2019

deps: update V8 to 7.8 #29493

deps: update V8 to 7.8 #29493

Conversation

ryzokuken commented Sep 8, 2019 • edited Loading

targos commented Sep 8, 2019 • edited Loading

nodejs-github-bot commented Sep 8, 2019

gengjiawen commented Sep 11, 2019

ryzokuken commented Sep 11, 2019

rvagg commented Sep 11, 2019

bnoordhuis commented Sep 12, 2019

gengjiawen commented Sep 12, 2019

ryzokuken commented Sep 12, 2019

mmarchini commented Sep 12, 2019

mhdawson commented Sep 12, 2019

sam-github commented Sep 17, 2019 • edited Loading

Trott commented Sep 17, 2019

sam-github commented Sep 18, 2019

mhdawson commented Sep 18, 2019

rvagg commented Sep 18, 2019

mhdawson commented Sep 19, 2019

gengjiawen commented Sep 20, 2019

rvagg commented Sep 20, 2019

MylesBorins commented Sep 24, 2019

mhdawson commented Sep 25, 2019

ryzokuken commented Sep 25, 2019

ryzokuken commented Sep 8, 2019 •

edited

Loading

targos commented Sep 8, 2019 •

edited

Loading

sam-github commented Sep 17, 2019 •

edited

Loading