doc: exitedAfterDisconnect value can be false #29404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the documentation to reflect the changes in the default value of worker.exitedAfterDisconnect Fixes: nodejs#28837 Refs: nodejs#3743
nodejs-github-bot
added
cluster
Trott
reviewed
Sep 3, 2019
|
Welcome @nimit95 and thanks for the pull request! I left a comment and hope it isn't too much trouble to add the requested details. |
|
@Trott thanks for the review, added the requested changes |
devnexen
approved these changes
Sep 4, 2019
Trott
reviewed
Sep 4, 2019
|
@nodejs/cluster |
Co-Authored-By: Rich Trott <[email protected]>
|
@nodejs/documentation |
danbev
added
the
author ready
|
Doesn't strictly need it, but could use another review. @nodejs/collaborators |
antsmartian
approved these changes
Sep 9, 2019
danbev
pushed a commit
that referenced
this pull request
Sep 9, 2019
Fixed the documentation to reflect the changes in the default value of worker.exitedAfterDisconnect PR-URL: #29404 Fixes: #28837 Refs: #3743 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
|
Landed in 695e819. 🎉 |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Fixed the documentation to reflect the changes in the default value of worker.exitedAfterDisconnect PR-URL: #29404 Fixes: #28837 Refs: #3743 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
Fixed the documentation to reflect the changes in the default value of worker.exitedAfterDisconnect PR-URL: #29404 Fixes: #28837 Refs: #3743 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect
Fixes: #28837
Refs: #3743
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes