Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: include network interfaces in report #28911

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 31, 2019

To assist in debugging networking issues.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report. labels Jul 31, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 2, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 2, 2019
PR-URL: nodejs#28911
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig merged commit 1592d0a into nodejs:master Aug 3, 2019
@cjihrig cjihrig deleted the ifs branch August 3, 2019 17:29
BridgeAR pushed a commit that referenced this pull request Aug 6, 2019
PR-URL: #28911
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BridgeAR added a commit that referenced this pull request Aug 6, 2019
Notable changes:

* assert:
  * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
    #28892
* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) #28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    #28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    #28682
* report:
  * Network interfaces get included in the report (cjihrig)
    #28911
* src:
  * `v8.getHeapCodeStatistics()` is now exported
    (Yuriy Vasiyarov) #27978

PR-URL: #29017
BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 6, 2019
Notable changes:

* assert:
  * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
    nodejs#28892
* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) nodejs#28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    nodejs#28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    nodejs#28682
* report:
  * Network interfaces get included in the report (cjihrig)
    nodejs#28911
* src:
  * `v8.getHeapCodeStatistics()` is now exported
    (Yuriy Vasiyarov) nodejs#27978

PR-URL: nodejs#29017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants