Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: refactor keep alive #28700

Closed
wants to merge 1 commit into from
Closed

http: refactor keep alive #28700

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 15, 2019 •
edited
Loading

This tries to simplify the code and make it easier to understand. Took me a while to get my head around the previous implementation.

Also minor perf improvement.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jul 15, 2019
@ronag ronag changed the title Http refactor keep alive http: refactor keep alive Jul 15, 2019
@ronag ronag force-pushed the http-refactor-keep-alive branch 5 times, most recently from 71d9bb8 to 6e0f839 Compare July 15, 2019 17:46
@ronag ronag mentioned this pull request Jul 15, 2019
Closed
@ronag
Copy link
Member Author

ronag commented Jul 18, 2019

ping @benjamingr

benjamingr
benjamingr approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a readability improvement IMO and it makes more sense for the destroySoon stuff to happen in the responseEnd and not responseKeepAlive method.

Thanks for this 🙏

@Trott
Copy link
Member

Trott commented Jul 18, 2019

@nodejs/http While not strictly necessary, another review or two here would be good.

@mcollina
Copy link
Member

This would need a rebase.

mcollina
mcollina approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25282/

@ronag ronag force-pushed the http-refactor-keep-alive branch 2 times, most recently from 350b4d7 to 625a60a Compare August 28, 2019 08:48
@ronag
Copy link
Member Author

ronag commented Aug 28, 2019

rebased

@benjamingr benjamingr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 28, 2019
@mcollina
Copy link
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1988/

@mcollina
Copy link
Member

mcollina commented Sep 8, 2019

Unfortunately it needs another rebase :(

@ronag
Copy link
Member Author

ronag commented Sep 8, 2019

Rebased

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25395/

@mcollina
Copy link
Member

mcollina commented Sep 8, 2019

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1996/

@mcollina
Copy link
Member

CITGM is ok.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25446/

@mcollina
Copy link
Member

There seems to be CI failures on specific environments... cc @Trott.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25469/

@Trott
Copy link
Member

Trott commented Sep 16, 2019

Landed in 627bb6b

Trott pushed a commit that referenced this pull request Sep 16, 2019
@ronag @Trott
http: refactor responseKeepAlive()
627bb6b 
This tries to simplify the code and make it easier to understand. Took
me a while to get my head around the previous implementation.

Also minor perf improvement.

PR-URL: #28700
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott closed this Sep 16, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
@ronag @targos
http: refactor responseKeepAlive()
e75661e 
This tries to simplify the code and make it easier to understand. Took
me a while to get my head around the previous implementation.

Also minor perf improvement.

PR-URL: #28700
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@ronag @BridgeAR
http: refactor responseKeepAlive()
31b0b52 
This tries to simplify the code and make it easier to understand. Took
me a while to get my head around the previous implementation.

Also minor perf improvement.

PR-URL: #28700
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ronag @Trott @mcollina @nodejs-github-bot @jasnell @benjamingr @trivikr