Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: context little mem leak fix #28452

Closed
wants to merge 1 commit into from
Closed

src: context little mem leak fix #28452

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Jun 27, 2019
joyeecheung
joyeecheung approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nicer if we just use a std::unique_ptr for it but LGTM anyway

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24120/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 30, 2019
@devnexen @Trott
src: fix small memory leak
20d099a 
PR-URL: nodejs#28452
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member

Trott commented Jun 30, 2019

Landed in 20d099a.

Thanks for the contribution! 🎉

@Trott Trott closed this Jun 30, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@devnexen @targos
src: fix small memory leak
1951ed0 
PR-URL: #28452
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 2, 2019
@devnexen @targos
src: fix small memory leak
624fd17 
PR-URL: #28452
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
@cjihrig cjihrig mentioned this pull request Jul 9, 2019
Merged
2 tasks
cjihrig added a commit to cjihrig/node that referenced this pull request Jul 12, 2019
@cjihrig
src: manage MakeContext() pointer with unique_ptr
641d57f 
PR-URL: nodejs#28616
Refs: nodejs#28452
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2019
@cjihrig @targos
src: manage MakeContext() pointer with unique_ptr
3c418d9 
PR-URL: #28616
Refs: #28452
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@devnexen @nodejs-github-bot @Trott @jasnell @addaleax @cjihrig @joyeecheung