doc: add documentation for invalid byte sequences #28249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added documentation on evaluating legal code points, and the behavior that stems from it otherwise. Fixes: nodejs#23280
nodejs-github-bot
added
buffer
jasnell
approved these changes
Jun 17, 2019
Trott
reviewed
Jul 5, 2019
Trott
reviewed
Jul 5, 2019
Trott
reviewed
Jul 5, 2019
Co-Authored-By: Rich Trott <[email protected]>
Co-Authored-By: Rich Trott <[email protected]>
Co-Authored-By: Rich Trott <[email protected]>
Trott
approved these changes
Jul 5, 2019
|
@nodejs/buffer |
addaleax
reviewed
Jul 5, 2019
|
|
||
| A `U+FFFD` replacement value | ||
| (representing the aforementioned replacement character) will be returned | ||
| in case of decoding errors (invalid unicode scalar values). |
There was a problem hiding this comment.
To be honest, I don’t understand most of the text or its relevance here… the text basically says that invalid UTF-8 byte sequences will be decoded into U+FFFD replacement characters and that no error will be thrown in those cases, right?
How do UTF-16 and ASCII relate to that? What does “non-legal Unicode value” mean? (I would guess that this refers to characters that would be beyond U+10FFFF – if that’s correct, can you clarify that in the text?)
|
ping @rexagod? |
2 tasks
|
ping @rexagod again |
|
@rexagod thank you very much for your contribution. I am closing this, since there was no follow-up on the comment. Please open a new PR or leave a comment in case you would like to continue working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added documentation on evaluating legal code points,
and the behavior that stems from it otherwise.
Fixes: #23280
Checklist