tools: update eslint to latest #28173
Conversation
|
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
the
lib / src
BridgeAR
added
the
author ready
|
Nit 1: Please specify what version you are upgrading to in the commit message. (Preferably what version we're upgrading from as well.) Nit 2: If I'm not mistaken, unneeded |
BridgeAR
force-pushed
the
update-eslint-to-latest
branch
from
1739468
to
70e595c
Compare
|
@Trott thanks, I forgot that it would complain about the comments if they are not required. I updated the PR and incorporated the suggestions. Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3675/ |
This updates eslint from v6.0.0-alpha.2 to v6.0.0-rc.0. This also removes eslint-disable comments about `bigint` typeof checks. Those would otherwise have caused linting errors now that `bigint` is accepted as valid entry.
BridgeAR
force-pushed
the
update-eslint-to-latest
branch
from
70e595c
to
0f116e5
Compare
|
Rebased due to conflicts. Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3686/ |
|
@BridgeAR And update this line to Line 16 in e4136c1 Refs: https://github.com/eslint/eslint/releases/tag/v6.0.0 |
|
Updated to the latest release. |
|
ESLint 6.0.1 was released. Please skip 6.0.0 before landing this. |
This updates eslint from v6.0.0-alpha.2 to v6.0.1 This also removes eslint-disable comments about `bigint` typeof checks. Those would otherwise have caused linting errors now that `bigint` is accepted as valid entry. PR-URL: nodejs#28173 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
|
Landed in ed8fc7e |
This updates eslint from v6.0.0-alpha.2 to v6.0.1 This also removes eslint-disable comments about `bigint` typeof checks. Those would otherwise have caused linting errors now that `bigint` is accepted as valid entry. PR-URL: #28173 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
This updates eslint from v6.0.0-alpha.2 to v6.0.1 This also removes eslint-disable comments about `bigint` typeof checks. Those would otherwise have caused linting errors now that `bigint` is accepted as valid entry. PR-URL: #28173 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes