Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move jhamhader to Collaborator Emeriti list #27707

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 15, 2019

Yuval confirmed in email that it's OK to move them to the Emeriti list.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

jhamhader hasn't authored/landed/reviewed code in quite some time. I sent
them an email asking about becoming Emeritus but did not get a response.
It's easy enough to re-onboard someone back to active status if they
become active again, so I think this is a pretty safe change to make.
I'll specifically request a review of this change from them so they get
notified and can comment/review/block/approve/etc. this.
@Trott Trott added the meta Issues and PRs related to the general management of the project. label May 15, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 15, 2019
@Trott Trott requested a review from jhamhader May 15, 2019 02:21
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2019
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this uncomfortable but important work Rich ❤️

@benjamingr
Copy link
Member

And thanks for your contribution jhamhader!

@benjamingr
Copy link
Member

I've pinged Yuval on a private channel and he said he is on holiday, has responded to Trott's email and will comment here when he is back from holiday :]

@Trott
Copy link
Member Author

Trott commented May 15, 2019

I've pinged Yuval on a private channel and he said he is on holiday, has responded to Trott's email and will comment here when he is back from holiday :]

Yuval's email was short, friendly, and said "no problem with moving to Emeriti list". I'll update the commit message on landing.

@Trott
Copy link
Member Author

Trott commented May 17, 2019

Landed in 776e000

@Trott Trott closed this May 17, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 17, 2019
Yuval confirmed in email that he could be moved to Collaborator Emeritus
status.

PR-URL: nodejs#27707
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request May 17, 2019
Yuval confirmed in email that he could be moved to Collaborator Emeritus
status.

PR-URL: #27707
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
4 tasks
@Trott Trott deleted the jhamhader2emeritus branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants