tools: update eslint #27670
tools: update eslint #27670
Conversation
This comment has been minimized.
This comment has been minimized.
|
@Trott I am fine to wait but isn't the referenced release another pre-release? I guess there's little downside to updating to the pre-release. I guess the worst that would happen is that we have to update more often? I wanted to see what would break and what we should update. The regular lint job passes locally with only a single rule adjusted. So that's quite nice. The CI job failed though and it seems like there's an issue around the new configuration. I fixed that locally and hope the CI passes now as well. |
|
@nodejs/build it seems like this would require a manual update to the |
Can you check if you comitted |
|
I don't have any opinion on this change, but @BridgeAR is correct that the May 24th ESLint release will in all likelihood be another prerelease, not the stable v6.0.0 release. (There isn't a set timeline for when the stable release will happen, but my best estimate would be sometime in June.) |
It's all here. I used the update script and running the |
This comment has been minimized.
This comment has been minimized.
|
@richardlau thanks, I saw the filename, not the folder and did not look further. It turned out that we ignored quite a lot of files that we should not have ignored. We probably still ignore doc linting files but I wanted to concentrate on this specific change for now. @refack PTAL |
|
|
|
This removes a lot of files now. The reason for that is that I used the new |
|
@Trott does this seem fine for you to land? I would otherwise split some parts into a different PR. |
BridgeAR
requested review from
targos,
ZYSzys,
antsmartian,
richardlau and
ryzokuken
No opinion from me. I'm fine if this lands, but I'm also fine with waiting until the stable release. |
BridgeAR
added
author ready
|
Rebased due to conflicts. |
This makes sure the "good" and "bad" examples are split into two. Otherwise it'll result in an parse error. PR-URL: nodejs#27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
PR-URL: nodejs#27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This makes sure the eslint config is up to date for eslint 6.0.0. PR-URL: nodejs#27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This activates the following recommended eslint rules: - no-async-promise-executor - no-shadow-restricted-names PR-URL: nodejs#27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This is just a minor update to use the newest latest version. PR-URL: nodejs#27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This updates out individual linting to work with eslint v6. Without this change the node_modules would also be checked for. PR-URL: nodejs#27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This increases the maximum number of files to lint per worker from 40 to 60 files. This should ideally reduce the total linting time a tiny bit. PR-URL: nodejs#27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
The `-f` flag was missing a space after the module version. PR-URL: nodejs#27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
|
Landed in fddc2d7...0cd112a 🎉 |
This makes sure the "good" and "bad" examples are split into two. Otherwise it'll result in an parse error. PR-URL: #27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
PR-URL: #27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This makes sure the eslint config is up to date for eslint 6.0.0. PR-URL: #27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This activates the following recommended eslint rules: - no-async-promise-executor - no-shadow-restricted-names PR-URL: #27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This is just a minor update to use the newest latest version. PR-URL: #27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This updates out individual linting to work with eslint v6. Without this change the node_modules would also be checked for. PR-URL: #27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
This increases the maximum number of files to lint per worker from 40 to 60 files. This should ideally reduce the total linting time a tiny bit. PR-URL: #27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
The `-f` flag was missing a space after the module version. PR-URL: #27670 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
Eslint v6 is still an alpha but we might want to update to that version nevertheless. That way we profit from recent fixes they implemented and there is probably little downside switching right now.
I also went ahead and activated two more eslint rules that are recommended by eslint. This update does not require any code changes besides changing one
builtinGlobalsoption forno-redeclare(the default changed but we should stick to the old value).Update: This also includes an update to the latest stable
bable-eslintmodule and removes a lot of files due to an update todmn.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes