-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add example to test doc for clarity #27561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @addityasingh! Welcome and thanks for the pull request! I feel like the way this changes the sentence to be a run-on sentence with confusing capitalization and seemingly out-of-place abbreviation usage does more harm to the text than benefit. It makes it harder to scan/read/understand. I think a better approach might be to update the example to specify the full path to the filename of the test file. That will make it more obvious what the sample code is doing without having to explain it in the text like this.
So, for example, maybe update the sample code to be this? $ python tools/test.py -J --mode=release test/parallel/test-stream2-transform.js Furthermore (and optionally--these things below are not required in this PR, but I'd be happy to see them myself), this can be simplified. Since this is an example of just running a single test, the $ python tools/test.py --mode=release test/parallel/test-stream2-transform.js And honestly, I'm not sure $ python tools/test.py test/parallel/test-stream2-transform.js Lastly, $ tools/test.py test/parallel/test-stream2-transform.js |
@Trott Thanks for the suggestions.
Agreed. I will remove the
I will remove it from this specific command
I disagree. For the sake of inter-operability and explicitness, we should still keep the On top of those, I would update the sentence to specify that the command is to execute all tests in a file and not just one test. Currently, its unclear if the command is intended to execute all the tests in same file or just a single test. |
de17ba0
to
c54b637
Compare
Update the documentation for test execution for tests in a single file
Co-Authored-By: addityasingh <[email protected]>
c54b637
to
0b105ac
Compare
Left two optional suggestions, but this looks good to me with or without those suggestions. |
Co-Authored-By: addityasingh <[email protected]>
@Trott Can you check now? I applied your suggestions |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Landed in fa3eefc 🎉 |
Update the documentation for test execution for tests in a single file PR-URL: #27561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Update the documentation for test execution for tests in a single file PR-URL: #27561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Add example to the test doc for clarity
Checklist