v11.15.0 proposal #27314
Merged
v11.15.0 proposal #27314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an error code property to invalid `secureProtocol` method exceptions. Backport-PR-URL: #26951 PR-URL: #24729 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
In #24729, the error was changed to be a TypeError, which is the standard type for this kind of error. However, it was Error in 11.x and earlier, so revert that single aspect, so the backport can be semver-minor. PR-URL: #26951 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
SSL errors have a long structured message, but lacked the standard .code property which can be used for stable comparisons. Add a `code` property, as well as the 3 string components of an SSL error: `reason`, `library`, and `function`. Backport-PR-URL: #26951 PR-URL: #25093 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This updates all sources in deps/openssl/openssl with openssl-1.1.1b. Backport-PR-URL: #26951 PR-URL: #26327 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This is a floating patch against OpenSSL-1.1.1 to generate asm files with Makefile rules. Backport-PR-URL: #26951 PR-URL: #26327 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Original: Fixes: #4270 PR-URL: #19794 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
`cd deps/openssl/config; make` updates all archs dependant files. Backport-PR-URL: #26951 PR-URL: #26327 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This introduces TLS1.3 support and makes it the default max protocol,
but also supports CLI/NODE_OPTIONS switches to disable it if necessary.
TLS1.3 is a major update to the TLS protocol, with many security
enhancements. It should be preferred over TLS1.2 whenever possible.
TLS1.3 is different enough that even though the OpenSSL APIs are
technically API/ABI compatible, that when TLS1.3 is negotiated, the
timing of protocol records and of callbacks broke assumptions hard-coded
into the 'tls' module.
This change introduces no API incompatibilities when TLS1.2 is
negotiated. It is the intention that it be backported to current and LTS
release lines with the default maximum TLS protocol reset to 'TLSv1.2'.
This will allow users of those lines to explicitly enable TLS1.3 if they
want.
API incompatibilities between TLS1.2 and TLS1.3 are:
- Renegotiation is not supported by TLS1.3 protocol, attempts to call
`.renegotiate()` will always fail.
- Compiling against a system OpenSSL lower than 1.1.1 is no longer
supported (OpenSSL-1.1.0 used to be supported with configure flags).
- Variations of `conn.write('data'); conn.destroy()` have undefined
behaviour according to the streams API. They may or may not send the
'data', and may or may not cause a ERR_STREAM_DESTROYED error to be
emitted. This has always been true, but conditions under which the write
suceeds is slightly but observably different when TLS1.3 is negotiated
vs when TLS1.2 or below is negotiated.
- If TLS1.3 is negotiated, and a server calls `conn.end()` in its
'secureConnection' listener without any data being written, the client
will not receive session tickets (no 'session' events will be emitted,
and `conn.getSession()` will never return a resumable session).
- The return value of `conn.getSession()` API may not return a resumable
session if called right after the handshake. The effect will be that
clients using the legacy `getSession()` API will resume sessions if
TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is
negotiated. See #25831 for more
information.
Backport-PR-URL: #26951
PR-URL: #26209
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
TLSv1.3 is still supported when explicitly configured, but it is not the default. PR-URL: #26951 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Backport-PR-URL: #26951 PR-URL: #26843 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Backport-PR-URL: #26951 PR-URL: #26843 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Backport-PR-URL: #26951 PR-URL: #26821 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #26951 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
For 11.x, the default minimum is TLSv1, so it needs a CLI switch to change the default to the more secure minimum of TLSv1.2. PR-URL: #26951 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
nodejs-github-bot
added
lib / src
codebytere
force-pushed
the
v11.15.0-proposal
branch
2 times, most recently
from
3669215
to
171465f
Compare
|
There's still one open backport: #27259. I am not sure if we want to have a small last release or if we want to include everything else as well that landed in the meanwhile @nodejs/releasers? |
|
The odd "Current" lines have always had at least 8 months support, so I'd hope that it's not being entirely dropped on the floor at the 6 month mark. |
|
@rvagg my recollection was that after 6 months current releases moved to maintenance mode. Below are all releases that were done for current release after 6 months, of the 5 releases only 1 of them seems to have been a non maintenance release. For 9.x there was only a single release after April: For 7.x there were two:
For 5.x there were two: |
|
Should i go ahead with what's here or get that last backport in? |
|
@MylesBorins yeah, that's fine and I think that's how we've framed it in the past, our support graphic has grey bits for those extra 2 months but our support table just has an EOL for June. My point is, that we shouldn't be dropping 11.x on the floor just because 12 is out. And, if someone wants to continue pushing releases out beyond security releases then I don't think there's a reason to stop that for the next couple of months. Maybe it'd even be a good way for someone new to releases to have learn the ropes? Of course if there's nobody that can be bothered then there's not much we can do about that either! |
|
@codebytere I think it'd be nice to get the last backport in this release |
|
It'd be nice to still get this in, imo. |
The differences to the original patch are the replacement of
`i::IsIdentifier...()` with `unicode_cache_.IsIdentifier...()`,
because the former is not available on Node.js v11.x, as well
as the omitted `no_gc` argument for `GetFlatContent()`.
Original commit message:
Assume flat string when checking CompileFunctionInContext arguments.
[email protected]
Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1388533
Reviewed-by: Jakob Kummerow <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#58562}
Refs: v8/v8@61f4c22
Fixes: #27256
PR-URL: #27259
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
codebytere
force-pushed
the
v11.15.0-proposal
branch
2 times, most recently
from
be5d7eb
to
9a7702f
Compare
BethGriggs
approved these changes
Apr 29, 2019
Notable changes: * deps: add s390 asm rules for OpenSSL-1.1.1 (Shigeki Ohtsu) [#19794](#19794) * src: add .code and SSL specific error properties (Sam Roberts) [#25093](#25093) * tls: * add --tls-min-v1.2 CLI switch (Sam Roberts) [#26951](#26951) * supported shared openssl 1.1.0 (Sam Roberts) [#26951](#26951) * revert default max toTLSv1.2 (Sam Roberts) [#26951](#26951) * revert change to invalid protocol error type (Sam Roberts) [#26951](#26951) * support TLSv1.3 (Sam Roberts) [#26209](#26209) * add code for ERR\_TLS\_INVALID\_PROTOCOL\_METHOD (Sam Roberts) [#24729](#24729) PR-URL: #27314
codebytere
force-pushed
the
v11.15.0-proposal
branch
from
9a7702f
to
e65a904
Compare
codebytere
added a commit
that referenced
this pull request
Apr 30, 2019
Notable changes: * deps: add s390 asm rules for OpenSSL-1.1.1 (Shigeki Ohtsu) [#19794](#19794) * src: add .code and SSL specific error properties (Sam Roberts) [#25093](#25093) * tls: * add --tls-min-v1.2 CLI switch (Sam Roberts) [#26951](#26951) * supported shared openssl 1.1.0 (Sam Roberts) [#26951](#26951) * revert default max toTLSv1.2 (Sam Roberts) [#26951](#26951) * revert change to invalid protocol error type (Sam Roberts) [#26951](#26951) * support TLSv1.3 (Sam Roberts) [#26209](#26209) * add code for ERR\_TLS\_INVALID\_PROTOCOL\_METHOD (Sam Roberts) [#24729](#24729) PR-URL: #27314
codebytere
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Apr 30, 2019
codebytere
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
Commits
8db791d0fe] - deps: update archs files for OpenSSL-1.1.1b (Sam Roberts) #263271c98b720b1] - (SEMVER-MINOR) deps: add s390 asm rules for OpenSSL-1.1.1 (Shigeki Ohtsu) #19794d8cc478ae9] - deps: upgrade openssl sources to 1.1.1b (Sam Roberts) #26327fa6f0f1644] - doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION (Sam Roberts) #268218b5d350a35] - (SEMVER-MINOR) src: add .code and SSL specific error properties (Sam Roberts) #25093bf2c283555] - (SEMVER-MINOR) tls: add --tls-min-v1.2 CLI switch (Sam Roberts) #269517aeca270f6] - (SEMVER-MINOR) tls: supported shared openssl 1.1.0 (Sam Roberts) #26951d2666e6ded] - tls: add debugging to native TLS code (Anna Henningsen) #26843225417b849] - tls: add CHECK for impossible condition (AnnaHenningsen) #26843109c097797] - (SEMVER-MINOR) tls: revert default max toTLSv1.2 (Sam Roberts) #269517393e37af1] - (SEMVER-MINOR) tls: support TLSv1.3 (Sam Roberts) #262098e14859459] - (SEMVER-MINOR) tls: revert change to invalid protocol error type (Sam Roberts) #2695100688b6042] - (SEMVER-MINOR) tls: add code for ERR_TLS_INVALID_PROTOCOL_METHOD (Sam Roberts) #24729