From 8998165d9d00f4d0de5413de4c07899ee6a13674 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 19 Apr 2019 20:04:16 +0800 Subject: [PATCH 1/3] test: skip test-cpu-prof in debug builds with code cache The CPU profiler crashes in debug builds when code cache is enabled. Skip the test temporarily until it's fixed. --- test/sequential/test-cpu-prof.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/sequential/test-cpu-prof.js b/test/sequential/test-cpu-prof.js index a13db4ac10ef4e..fa29d1d88d9626 100644 --- a/test/sequential/test-cpu-prof.js +++ b/test/sequential/test-cpu-prof.js @@ -3,6 +3,13 @@ // This tests that --cpu-prof and --cpu-prof-path works. const common = require('../common'); +if (process.features.debug && + process.config.variables.node_code_cache_path == 'yes') { + // FIXME(joyeecheung): the profiler crashes when code cache + // is enabled in debug builds. + common.skip('--prof does not work in debug builds with code cache'); +} + const fixtures = require('../common/fixtures'); common.skipIfInspectorDisabled(); From c26bf3f8e95f0e8faba390d22bbb421bb7d2c917 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 19 Apr 2019 20:11:42 +0800 Subject: [PATCH 2/3] fixup! test: skip test-cpu-prof in debug builds with code cache --- test/sequential/test-cpu-prof.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/sequential/test-cpu-prof.js b/test/sequential/test-cpu-prof.js index fa29d1d88d9626..8582da7545b7ac 100644 --- a/test/sequential/test-cpu-prof.js +++ b/test/sequential/test-cpu-prof.js @@ -4,7 +4,7 @@ const common = require('../common'); if (process.features.debug && - process.config.variables.node_code_cache_path == 'yes') { + process.config.variables.node_code_cache_path === 'yes') { // FIXME(joyeecheung): the profiler crashes when code cache // is enabled in debug builds. common.skip('--prof does not work in debug builds with code cache'); From f7d81e5f82f490fe9c1d64b052641bd7ea5a65ea Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 19 Apr 2019 20:13:09 +0800 Subject: [PATCH 3/3] fixup! fixup! test: skip test-cpu-prof in debug builds with code cache --- test/sequential/test-cpu-prof.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/sequential/test-cpu-prof.js b/test/sequential/test-cpu-prof.js index 8582da7545b7ac..8b9001ba674e23 100644 --- a/test/sequential/test-cpu-prof.js +++ b/test/sequential/test-cpu-prof.js @@ -7,7 +7,7 @@ if (process.features.debug && process.config.variables.node_code_cache_path === 'yes') { // FIXME(joyeecheung): the profiler crashes when code cache // is enabled in debug builds. - common.skip('--prof does not work in debug builds with code cache'); + common.skip('--cpu-prof does not work in debug builds with code cache'); } const fixtures = require('../common/fixtures');