Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: stricter buffer from #27051

Closed
wants to merge 3 commits into from
Closed

buffer: stricter buffer from #27051

wants to merge 3 commits into from

Commits on Jan 12, 2020

  1. buffer: stricter Buffer.from byteOffset check 

    This validates the byteOffset stricter to prevent ambiguous inputs
from being handled in unknown ways.
    @BridgeAR
    BridgeAR committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    0abf9b0 View commit details
    Browse the repository at this point in the history

  2. buffer: remove support for unknown objects 

    So far objects with a `length` property that was not an integer or
positive resulted in an empty buffer being created. That is not ideal
as it's not really clear what the intention in was.
This throws an error from now on instead.
    @BridgeAR
    BridgeAR committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    1ed3193 View commit details
    Browse the repository at this point in the history

  3. doc: remove the buffer example using Symbol.toPrimitive 

    The single buffer API is the only one supporting Symbol.toPrimitive
but ideally it should not be used. Remove the documentation to
prevent users from potentially using this API.
    @BridgeAR
    BridgeAR committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    99bdafc View commit details
    Browse the repository at this point in the history