Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: edit "How Can I Help?" in Collaborator Guide #26895

Closed
wants to merge 2 commits into from
Closed

doc: edit "How Can I Help?" in Collaborator Guide #26895

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 24, 2019

Edit the "How Can I Help?" section of the Collaborator Guide to keep
sentences simple, short, and direct.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: edit "How Can I Help?" in Collaborator Guide
8efc417 
Edit the "How Can I Help?" section of the Collaborator Guide to keep
sentences simple, short, and direct.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3028/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 24, 2019
@Trott
Copy link
Member Author

Trott commented Mar 25, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3029/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
@Trott
Copy link
Member Author

Trott commented Mar 26, 2019

Landed in 6342af7

@Trott Trott closed this Mar 26, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 26, 2019
@Trott
doc: edit "How Can I Help?" in Collaborator Guide
6342af7 
Edit the "How Can I Help?" section of the Collaborator Guide to keep
sentences simple, short, and direct.

PR-URL: nodejs#26895
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@Trott @targos
doc: edit "How Can I Help?" in Collaborator Guide
7386c62 
Edit the "How Can I Help?" section of the Collaborator Guide to keep
sentences simple, short, and direct.

PR-URL: nodejs#26895
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
@Trott @targos
doc: edit "How Can I Help?" in Collaborator Guide
a545cfe 
Edit the "How Can I Help?" section of the Collaborator Guide to keep
sentences simple, short, and direct.

PR-URL: #26895
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Mar 27, 2019
Merged
@Trott Trott deleted the how-can-i-help branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @danbev @jasnell @BridgeAR @ZYSzys