Merge vee-eight-4.5 into master #2682
Conversation
|
LGTM. How should I land it @rvagg? |
|
You may also need to re-apply 37fcd0b |
|
@Fishrock123 thanks for mentioning that. I was not aware of that floating patch. Let me look into it. |
|
@ofrobots you want some help with this? |
|
@indutny @Fishrock123 Do I need a PR to cherry-pick 37fcd0b onto vee-eight-4.5? In interest of expediency I might make more sense for me to add it to this PR (i.e. cherry-pick then push to vee-eight-4.5) and re-spin a CI. |
|
Cherry-picked the commit into this PR. New CI: https://ci.nodejs.org/job/node-test-pull-request/247/ |
|
Once the CI passes, my plan is to rebase this onto master and push, as we have an LGTM already. |
Upgrade to the latest branch-head for V8 4.5. For the full commit log see https://github.com/v8/v8-git-mirror/commits/4.5.103.24 PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
Apply the src/node_contextify.cc and lib/module.js fixups from @bnoordhuis 41e63fb PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
The `context_` is not initialized until the `CreateV8Context` will return. Make sure that it will be empty (by moving away initialization from constructor) at start, and ignore getter callbacks until it will have some value. PR-URL: #2091 Reviewed-By: Trevor Norris <[email protected]>
The list of Array properties needed to be updated to match the new ones added in V8 4.5. PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
Turn on V8 API deprecation warnings. Fix up the no-arg Isolate::New() calls in src/node.cc and src/debug-agent.cc. PR-URL: #2091 Reviewed-By: Trevor Norris <[email protected]>
v8::Handle is deprecated: https://codereview.chromium.org/1224623004 PR-URL: #2202 Reviewed-By: Ben Noordhuis <[email protected]>
The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6 no longer manifests with (at least) 4.5.103.20. [1] See https://code.google.com/p/v8/issues/detail?id=4338 PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
Ref: #1376 Ref: #1398 Issue fixed in V8: https://chromium.googlesource.com/v8/v8/+/81703350bbb9923d211fe5b79e90bd458b0916e2 V8-Bug: https://code.google.com/p/v8/issues/detail?id=4019 PR-URL: #2592 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Pick up v8/v8@f9a0a16 Commit log at https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 PR-URL: #2632 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: rvagg - Rod Vagg <[email protected]>
|
Scratch that. I need to run a CI after rebasing. |
ofrobots
force-pushed
the
vee-eight-4.5
branch
from
8219b60
to
262e147
Compare
|
CI after rebasing onto master: https://ci.nodejs.org/job/node-test-pull-request/248/ |
|
|
|
just as a matter of process folks, when a V8 goes stable, if we get CI happy then they can be merged into master, the only time it might matter is when we're close to cutting a new stable branch and we might need to have a quick discussion about whether it'll end up in that stable or not. wrt v4, we already have a |
ofrobots
force-pushed
the
vee-eight-4.5
branch
from
262e147
to
64beab0
Compare
|
Dropped 262e147 (NODE_MODULE_VERSION bump) as per #2678 (comment). |
|
37fcd0b is still in there. I guess @ofrobots did some creative rebasing so that it didn't need to be applied again? |
|
There was nothing creative on my part. I think git was smart enough to realize that the commit was a np-op after the rebase and dropped it the commit from the being-rebased branch. |
This brings V8 4.5 into master.
Ref: #2632
R=@rvagg
/cc @nodejs/v8