lib: remove usage of require('util') #26779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the usage of `require('util').inspect`.
Refs: nodejs#26546
nodejs-github-bot
added
the
encoding
dnlup
commented
Mar 19, 2019
| @@ -327,7 +327,7 @@ class TextEncoder { | |||
| }); | |||
| obj.encoding = this.encoding; | |||
| // Lazy to avoid circular dependency | |||
| return require('util').inspect(obj, opts); | |||
| return require('internal/util/inspect').inspect(obj, opts); | |||
There was a problem hiding this comment.
If it was possible to change
Line 21 in 1329d0a
to
customInspectSymbol: <something else>I could put require('internal/util/inspect').inspect together with all the top level imports.
dnlup
commented
Mar 19, 2019
| @@ -530,7 +530,7 @@ function makeTextDecoderJS() { | |||
| obj[kHandle] = this[kHandle]; | |||
| } | |||
| // Lazy to avoid circular dependency | |||
| return require('util').inspect(obj, opts); | |||
| return require('internal/util/inspect').inspect(obj, opts); | |||
There was a problem hiding this comment.
BridgeAR
approved these changes
Mar 22, 2019
BridgeAR
added
the
author ready
ZYSzys
approved these changes
Mar 22, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 24, 2019
Remove the usage of `require('util').inspect`.
PR-URL: nodejs#26779
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
|
Landed in e5383ad 🎉 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Remove the usage of `require('util').inspect`.
PR-URL: nodejs#26779
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Remove the usage of `require('util').inspect`.
PR-URL: #26779
Refs: #26546
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of
require('util').inspect.Refs: #26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes