v6.17.1 proposal #26684
v6.17.1 proposal #26684
Conversation
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Fixes: #12572 Refs: #16240 PR-URL: #23746 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #23989 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #24575 Refs: #24551 Refs: #12958 Refs: #12957 Refs: #8325 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Richard Lau <[email protected]>
In 180f865, the test was changed so that the `env` argument of `createInternalRepl()` also contained external environment variables, because keeping them can be necessary for spawning processes on some systems. However, this test does not spawn new processes, and relies on the fact that the environment variables it tests are not already set (and fails otherwise); therefore, reverting to the original state should fix this. Fixes: #21451 Fixes: nodejs/build#1377 Refs: #25219 PR-URL: #25226 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refs: #24738 Fixes: #25858 PR-URL: #25939 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: #25444 Backport-PR-URL: #26478 PR-URL: #25447 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
added
lib / src
|
Running CI test preemptively: https://ci.nodejs.org/job/node-test-pull-request/21566/ to make sure the CI infra is still compatible with v6 |
BethGriggs
force-pushed
the
v6.17.1-proposal
branch
from
83598c4
to
8051716
Compare
BethGriggs
force-pushed
the
v6.17.1-proposal
branch
from
8051716
to
f34c917
Compare
|
There's just one open PR for v6.x that would be good to get into this release |
BethGriggs
force-pushed
the
v6.17.1-proposal
branch
from
f34c917
to
4fd8cd3
Compare
|
CITGM against v6.x: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1792/ |
|
Seeing addons failures on Windows on the latest CI (https://ci.nodejs.org/job/node-test-binary-windows-2/53/), I'm assuming it is the same issue as @richardlau mentioned in nodejs/reliability#22 (comment) |
It's my fault. I'm on it. |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22123/ Failed with: |
|
Still trying to work out where the sequential/test-child-process-pass-fd failure on one Windows distribution is coming from 🤔 It seems to also be failing on v6.x - (https://ci.nodejs.org/job/node-test-commit/27415/) |
|
So it seems like the issue is related to this OS issue (it causes node to start slow and hog 100% cpu for ~1 second). This specific test creates 80 sub-processes in a tight loop, and it just times out at 60 seconds (when it needs ~77). I'm cleaning the update cache on https://ci.nodejs.org/computer/test-azure_msft-win2008r2-x64-1/ to see if that solves the issue. |
BethGriggs
force-pushed
the
v6.17.1-proposal
branch
from
4fd8cd3
to
94b3b03
Compare
BethGriggs
force-pushed
the
v6.17.1-proposal
branch
from
94b3b03
to
576c2bf
Compare
2019-04-02, Version 6.17.1'Boron' (LTS), @BethGriggs
Node 6 is due to go End-of-Life on 2019-04-30.
Notable Changes
Execute()(Brian White) #25939Commits
c9d21a0c10] - build: set-blibpath:for AIX (Richard Lau) #254479ba5fd6bad] - build: only check REPLACEME & DEP...X for releases (Rod Vagg) #245751371a6f88b] - doc: simplify CODE_OF_CONDUCT.md (Rich Trott) #23989ad62971573] - doc: document that addMembership must be called once in a cluster (James M Snell) #237468080a9bf40] - http: fix error check inExecute()(Brian White) #25939aedc7120ea] - src: fix bootstrap_node on bsd (sylkat) #22663b5d464955a] - test: fix test-repl-envvars (Anna Henningsen) #25226This is the last planned release for Node 6.