test: use emitter.listenerCount() in test-http-connect #26031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `emitter.listenerCount()` instead of the `length` property of the array returned by `emitter.listeners()`.
|
I understand this has very little value but using It's ok if this is not accepted. |
jasnell
approved these changes
Feb 11, 2019
danbev
approved these changes
Feb 13, 2019
addaleax
approved these changes
Feb 13, 2019
|
Landed in 2b090c1 |
addaleax
pushed a commit
that referenced
this pull request
Feb 13, 2019
Use `emitter.listenerCount()` instead of the `length` property of the array returned by `emitter.listeners()`. PR-URL: #26031 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 14, 2019
Use `emitter.listenerCount()` instead of the `length` property of the array returned by `emitter.listeners()`. PR-URL: #26031 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
emitter.listenerCount()instead of thelengthproperty of thearray returned by
emitter.listeners().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes