process: normalize process.execPath in CreateProcessObject()

[joyeecheung]

Directly normalize process.execPath using uv_fs_realpath
on OpenBSD before serializing it into the process object,
instead of using require('fs') to normalize and override
the path in bootstrap/node.js.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2543/pipeline

[richardlau]

Changes LGTM but I wonder whether the original change for OpenBSD should have been pushed up to libuv.

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/20657/

[bnoordhuis]

I second what Richard says. If uv_exepath() behaves differently from other unices on openbsd then it would be best to fix it in libuv, not here.

[cjihrig]

I second what Richard says. If uv_exepath() behaves differently from other unices on openbsd then it would be best to fix it in libuv, not here.

I agree with that too. The only issue is that we don't test OpenBSD in the CI (AFAIK), so someone would have to set that up first to fix it with any confidence.

[joyeecheung]

I agree this can be done in libuv instead, though this just moves what we already do to the C++. We can come back removing the special case code when this gets done in the upstream.

[joyeecheung]

Landed in af83f6a