Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean deprecate code in agent.h #25914

Closed
wants to merge 1 commit into from
Closed

src: clean deprecate code in agent.h #25914

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 4, 2019
@gengjiawen
Copy link
Member Author

@addaleax Can you review this pr ? Thanks.

addaleax
addaleax approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d remove the reference to deprecation in the commit message – this just removes an unused declaration, right?

@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20612/

@gengjiawen
Copy link
Member Author

@addaleax I have fixed the commit message.

@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

Rebuild CI: https://ci.nodejs.org/job/node-test-pull-request/20623/

@danbev
Copy link
Contributor

danbev commented Feb 7, 2019

Landed in 0e54a0a.

@danbev danbev closed this Feb 7, 2019
danbev pushed a commit that referenced this pull request Feb 7, 2019
@gengjiawen @danbev
src: clean unused code in agent.h
0e54a0a 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25914
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
@gengjiawen @addaleax
src: clean unused code in agent.h
f5d5034 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25914
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @addaleax @danbev @jasnell @nodejs-github-bot