From 263bdcb46ed4a17e7426ff4e250bb5ff529ef4e5 Mon Sep 17 00:00:00 2001 From: Sakthipriyan Vairamani Date: Fri, 28 Aug 2015 07:20:39 +0530 Subject: [PATCH] test: use tmp directory in chdir test This patch - makes chdir test to use the tmp directory - moves the test to parallel - renames the file to test-process-chdir as chdir is in process module --- test/parallel/test-process-chdir.js | 28 +++++++++++++++++++++ test/sequential/test-chdir.js | 38 ----------------------------- 2 files changed, 28 insertions(+), 38 deletions(-) create mode 100644 test/parallel/test-process-chdir.js delete mode 100644 test/sequential/test-chdir.js diff --git a/test/parallel/test-process-chdir.js b/test/parallel/test-process-chdir.js new file mode 100644 index 00000000000000..ed8bf83af47b22 --- /dev/null +++ b/test/parallel/test-process-chdir.js @@ -0,0 +1,28 @@ +'use strict'; + +const common = require('../common'); +const assert = require('assert'); +const fs = require('fs'); +const path = require('path'); + +assert.notStrictEqual(process.cwd(), __dirname); +process.chdir(__dirname); +assert.strictEqual(process.cwd(), __dirname); + +const dir = path.resolve(common.tmpDir, + 'weird \uc3a4\uc3ab\uc3af characters \u00e1\u00e2\u00e3'); + +// Make sure that the tmp directory is clean +common.refreshTmpDir(); + +fs.mkdirSync(dir); +process.chdir(dir); +assert.strictEqual(process.cwd(), dir); + +process.chdir('..'); +assert.strictEqual(process.cwd(), path.resolve(common.tmpDir)); + +assert.throws(function() { process.chdir({}); }, TypeError, 'Bad argument.'); +assert.throws(function() { process.chdir(); }, TypeError, 'Bad argument.'); +assert.throws(function() { process.chdir('x', 'y'); }, + TypeError, 'Bad argument.'); diff --git a/test/sequential/test-chdir.js b/test/sequential/test-chdir.js deleted file mode 100644 index bab421e1e650c4..00000000000000 --- a/test/sequential/test-chdir.js +++ /dev/null @@ -1,38 +0,0 @@ -'use strict'; -var common = require('../common'); -var assert = require('assert'); -var fs = require('fs'); -var path = require('path'); - -assert.equal(true, process.cwd() !== __dirname); - -process.chdir(__dirname); -assert.equal(true, process.cwd() === __dirname); - -var dir = path.resolve(common.fixturesDir, - 'weird \uc3a4\uc3ab\uc3af characters \u00e1\u00e2\u00e3'); - -try { - fs.mkdirSync(dir); -} catch (e) { - if (e.code !== 'EEXIST') { - cleanup(); - throw e; - } -} - -process.chdir(dir); -assert(process.cwd() == dir); - -process.chdir('..'); -assert(process.cwd() == path.resolve(common.fixturesDir)); -cleanup(); - -assert.throws(function() { process.chdir({}); }, TypeError, 'Bad argument.'); -assert.throws(function() { process.chdir(); }, TypeError, 'Bad argument.'); -assert.throws(function() { process.chdir('x', 'y'); }, - TypeError, 'Bad argument.'); - -function cleanup() { - fs.rmdirSync(dir); -}