test: do not fail SLOW tests if they are not slow #25868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
richardlau
approved these changes
Feb 1, 2019
2 tasks
danbev
approved these changes
Feb 1, 2019
refack
approved these changes
Feb 1, 2019
addaleax
approved these changes
Feb 2, 2019
addaleax
added
the
author ready
devsnek
approved these changes
Feb 2, 2019
|
Looks like some Jenkins related issue? |
Should be solved. |
refack
added
landed
and removed
author ready
|
Landed in dfe5f8f |
refack
pushed a commit
that referenced
this pull request
Feb 4, 2019
PR-URL: #25868 Refs: #25867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
PR-URL: #25868 Refs: #25867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Merged
This was referenced Feb 15, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2019
PR-URL: #25868 Refs: #25867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #25868 Refs: #25867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make SLOW imply PASS.
Refs: #25867
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes