Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp call #25706

Closed
wants to merge 1 commit into from

Commits on Jan 25, 2019

  1. tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp call

    SSL_set_tlsext_status_ocsp_resp expects the data to be allocated with
    OPENSSL_malloc, not libc malloc, so use OpenSSLMalloc.
    
    Additionally, though OpenSSL doesn't type-check due to it being a macro,
    the function is documented to take an unsigned char pointer:
    https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
    
    (By default, OPENSSL_malloc is the same as libc malloc, but it is
    possible to customize this.)
    davidben committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    8ea19c9 View commit details
    Browse the repository at this point in the history