Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix macro duplicate declaration in env.h #25703

Closed
wants to merge 1 commit into from
Closed

src: fix macro duplicate declaration in env.h #25703

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 25, 2019
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20331/

@addaleax
Copy link
Member

Rebuild CI: https://ci.nodejs.org/job/node-test-pull-request/20362/

@danbev
Copy link
Contributor

danbev commented Jan 28, 2019

Landed in 1d60794.

@danbev danbev closed this Jan 28, 2019
danbev pushed a commit that referenced this pull request Jan 28, 2019
@gengjiawen @danbev
src: fix macro duplicate declaration in env.h
1d60794 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@gengjiawen @addaleax
src: fix macro duplicate declaration in env.h
021d197 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jan 29, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@gengjiawen @BethGriggs
src: fix macro duplicate declaration in env.h
44b9545 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@gengjiawen @BethGriggs
src: fix macro duplicate declaration in env.h
34f6b96 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@gengjiawen @MylesBorins
src: fix macro duplicate declaration in env.h
b31035d 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25703
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @addaleax @danbev @jasnell @cjihrig @nodejs-github-bot