Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove s_client from test-tls-ci-reneg-attack #25700

Closed
wants to merge 1 commit into from
Closed

test: remove s_client from test-tls-ci-reneg-attack #25700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 21 additions & 36 deletions test/pummel/test-tls-ci-reneg-attack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ if (!common.opensslCli)
common.skip('node compiled without OpenSSL CLI.');

const assert = require('assert');
const spawn = require('child_process').spawn;
const tls = require('tls');
const fixtures = require('../common/fixtures');

Expand All @@ -51,63 +50,49 @@ function test(next) {
key: fixtures.readSync('test_key.pem')
};

let seenError = false;

const server = tls.createServer(options, function(conn) {
conn.on('error', function(err) {
console.error(`Caught exception: ${err}`);
assert(/TLS session renegotiation attack/.test(err));
conn.destroy();
seenError = true;
});
conn.pipe(conn);
});

server.listen(common.PORT, function() {
const args = (`s_client -connect 127.0.0.1:${common.PORT}`).split(' ');
const child = spawn(common.opensslCli, args);

child.stdout.resume();
child.stderr.resume();
server.listen(0, function() {
const options = {
host: server.address().host,
port: server.address().port,
rejectUnauthorized: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a trailing comma?

};
const client = tls.connect(options, spam);

// Count handshakes, start the attack after the initial handshake is done
let handshakes = 0;
let renegs = 0;

child.stderr.on('data', function(data) {
if (seenError) return;
handshakes += ((String(data)).match(/verify return:1/g) || []).length;
if (handshakes === 2) spam();
renegs += ((String(data)).match(/RENEGOTIATING/g) || []).length;
});

child.on('exit', function() {
client.on('close', function() {
assert.strictEqual(renegs, tls.CLIENT_RENEG_LIMIT + 1);
server.close();
process.nextTick(next);
});

let closed = false;
child.stdin.on('error', function(err) {
switch (err.code) {
case 'ECONNRESET':
case 'EPIPE':
break;
default:
assert.strictEqual(err.code, 'ECONNRESET');
break;
}
closed = true;
client.on('error', function(err) {
console.log('CLIENT ERR', err);
throw err;
});
child.stdin.on('close', function() {
closed = true;

client.on('close', function(hadErr) {
assert.strictEqual(hadErr, false);
});

// simulate renegotiation attack
function spam() {
if (closed) return;
child.stdin.write('R\n');
setTimeout(spam, 50);
client.write('');
client.renegotiate({}, (err) => {
assert.ifError(err);
assert.ok(renegs <= tls.CLIENT_RENEG_LIMIT);
spam();
});
renegs++;
}
});
}