test: remove s_client from test-tls-ci-reneg-attack #25700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
force-pushed
the
rm-client
branch
2 times, most recently
from
0612d49
to
585e158
Compare
Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client. Refs: nodejs#25676 (comment)
|
Lite CI (because pummel tests are not run in regular CI): https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2397/ node-daily-master custom suite test that runs pummel modified to run against this PR and only run this test (because this is not the only broken pummel test right now): https://ci.nodejs.org/job/node-test-commit-custom-suites/840/ |
Trott
added
author ready
This was referenced Jan 26, 2019
bnoordhuis
approved these changes
Jan 26, 2019
| const options = { | ||
| host: server.address().host, | ||
| port: server.address().port, | ||
| rejectUnauthorized: false |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 27, 2019
Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client. Refs: nodejs#25676 (comment) PR-URL: nodejs#25700 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in c421619 |
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client. Refs: #25676 (comment) PR-URL: #25700 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client. Refs: #25676 (comment) PR-URL: #25700 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of
external (and potentially unpredictable/quirky/buggy) s_client.
Refs: #25676 (comment)
This test is currently broken (due to a quirk in a recent s_client update that we haven't worked around yet, see Ref above) and this change fixes it. The test is only run once a day in CI (because it's in pummel) so the breakage went unnoticed when the OpenSSL update landed a few days ago. A subsequent PR could probably move this test out of pummel. It seems like it could reasonably run in sequential or maybe even parallel.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes