process: fix call process.reallyExit, vs., binding #25655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
added
process
|
all thanks goes to @addaleax for this patch. |
devsnek
approved these changes
Jan 23, 2019
|
👍 for fix and test |
addaleax
approved these changes
Jan 23, 2019
BridgeAR
approved these changes
Jan 23, 2019
cjihrig
approved these changes
Jan 23, 2019
|
Should we fast track this to get the fix for 11.7.0 out asap? |
Some user-land modules, e.g., nyc, mocha, currently rely on patching process.reallyExit.
|
@MylesBorins looks like folks are okay with fast-track, I will land this as soon as the smoke test finishes with @joyeecheung's copy edits. |
bcoe
added a commit
to bcoe/node-1
that referenced
this pull request
Jan 23, 2019
Some user-land modules, e.g., nyc, mocha, currently rely on patching process.reallyExit. PR-URL: nodejs#25655 Fixes: nodejs#25650 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in a6286e6 |
|
@MylesBorins landed \o/ need to run to coffee, perhaps someone else can cherry-pick it to 11.7? |
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
Some user-land modules, e.g., nyc, mocha, currently rely on patching process.reallyExit. PR-URL: #25655 Fixes: #25650 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some user-land modules, e.g., nyc, mocha, currently rely on patching
process.reallyExit.
[email protected] breaks the interaction between nyc and mocha; ultimately it appears as though the problem is that nyc relies on overriding
process.reallyExitto output coverage to disk, which was replaced withbinding.reallyExit(dde7152).fixes: #25650
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes