-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] use NativeModuleLoader to compile all the bootstrappers #25446
[11.x] use NativeModuleLoader to compile all the bootstrappers #25446
Commits on Jan 10, 2019
-
lib: remove internalBinding('config').pendingDeprecation
Instead use `require('internal/options').getOptionValue('--pending-deprecation')` PR-URL: nodejs#24962 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 617bfe4 - Browse repository at this point
Copy the full SHA 617bfe4View commit details -
inspector: move process.binding to internalBinding
In places of process.binding('inspector'), migrate code to adapt internalBinding. PR-URL: nodejs#24931 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c168672 - Browse repository at this point
Copy the full SHA c168672View commit details -
util: inspect ArrayBuffers contents as well
Inspecting an ArrayBuffer now also shows their binary contents. PR-URL: nodejs#25006 Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dc4e5c5 - Browse repository at this point
Copy the full SHA dc4e5c5View commit details -
lib: remove internal
util._extends()
usageThis removes all internal calls to the deprecated `_extends()` function. It is slower than `Object.assign()` and the object spread notation since V8 6.8 and using the spread notation often also results in shorter code. PR-URL: nodejs#25105 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c67a51 - Browse repository at this point
Copy the full SHA 0c67a51View commit details -
lib: expose all type checks from the internal types module
Combine all type checks on the internal types module and do not use the types binding anywhere else anymore. This makes sure all of those checks exist when required. PR-URL: nodejs#25149 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e97acf7 - Browse repository at this point
Copy the full SHA e97acf7View commit details -
buffer: inspect extra properties
This makes sure extra properties on buffers are not ignored anymore when inspecting the buffer. PR-URL: nodejs#25150 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 95fa3c7 - Browse repository at this point
Copy the full SHA 95fa3c7View commit details -
lib: move lib/console.js to lib/internal/console/constructor.js
This is a broken commit: it's here so that git interpret this as a file move and preserve most of the history of the Console constructor. PR-URL: nodejs#24709 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ff4402 - Browse repository at this point
Copy the full SHA 7ff4402View commit details -
console: split console into global.js and constructor.js
Since we do not actually use the Console constructor to instantiate the global console, move the two piece of code into two different JS files for clarity, and make console.js a mere re-export of the global console. The hope is to make the global console, a namespace, more web-compatible while keeping the Console constructor available for backwards compatibility. PR-URL: nodejs#24709 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2f1f009 - Browse repository at this point
Copy the full SHA 2f1f009View commit details -
console: move the inspector console wrapping in a separate file
Move the wrapping of the inspector console in a separate file for clarity. In addition, save the original console from the VM explicitly via an exported property `require('internal/console/inspector').consoleFromVM` that `require('inspector').console` can alias to it later, instead of hanging the original console onto `per_thread.js` during bootstrap and counting on that `per_thread.js` only gets evaluated once and gets cached. PR-URL: nodejs#24709 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6280cda - Browse repository at this point
Copy the full SHA 6280cdaView commit details -
console: add
inspectOptions
optionAdd an `inspectOptions` option to the `console` constructor. That way it's possible to define all inspection defaults for each `console` instance instead of relying on the `inspect()` defaults. PR-URL: nodejs#24978 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6bf7511 - Browse repository at this point
Copy the full SHA 6bf7511View commit details -
console: improve inspectOptions validation
This commit adds stricter type checking to the inspectOptions option to the Console constructor. PR-URL: nodejs#25090 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 049b24d - Browse repository at this point
Copy the full SHA 049b24dView commit details -
process: provide dummy stdio for non-console Windows apps
The only known condition where we could not provide appropriate stdio streams so far were non-console Windows applications. Since this issue has come up a few times in our issue tracker now, switch to providing dummy streams for these cases instead. If there are other valid cases in which `uv_guess_handle` fails, and where there is a more sensible way to provide stdio, we’ll probably still find out because the streams don’t work properly either way. Refs: nodejs/help#1251 PR-URL: nodejs#20640 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8d166c9 - Browse repository at this point
Copy the full SHA 8d166c9View commit details
Commits on Jan 11, 2019
-
Revert "lib: expose all type checks from the internal types module"
This reverts commit e97acf7.
Configuration menu - View commit details
-
Copy full SHA for c219b8f - Browse repository at this point
Copy the full SHA c219b8fView commit details -
Revert "inspector: move process.binding to internalBinding"
This reverts commit c168672.
Configuration menu - View commit details
-
Copy full SHA for f4dbe57 - Browse repository at this point
Copy the full SHA f4dbe57View commit details -
Revert "lib: remove internalBinding('config').pendingDeprecation"
This reverts commit 617bfe4.
Configuration menu - View commit details
-
Copy full SHA for 7aeec97 - Browse repository at this point
Copy the full SHA 7aeec97View commit details -
Revert "os: move process.binding('os') to internalBinding"
This reverts commit 55d185f.
Configuration menu - View commit details
-
Copy full SHA for 48dfda7 - Browse repository at this point
Copy the full SHA 48dfda7View commit details -
Revert "lib: remove unused NativeModule/NativeModule wraps"
This reverts commit 0cde1a4.
Configuration menu - View commit details
-
Copy full SHA for abfde34 - Browse repository at this point
Copy the full SHA abfde34View commit details -
Revert "src,lib: make process.binding('config') internal"
This reverts commit 88a5449.
Configuration menu - View commit details
-
Copy full SHA for c5b2c31 - Browse repository at this point
Copy the full SHA c5b2c31View commit details -
Revert "lib: remove duplicated noop function"
This reverts commit 1ec4f8d.
Configuration menu - View commit details
-
Copy full SHA for fb6f2f2 - Browse repository at this point
Copy the full SHA fb6f2f2View commit details -
fs: make process.binding('fs') internal
Refs: nodejs#22160 PR-URL: nodejs#22478 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 106b299 - Browse repository at this point
Copy the full SHA 106b299View commit details -
src: use NativeModuleLoader to compile all the bootstrappers
This patch moves all the bootstrapper compilation to use NativeModuleLoader::CompileAndCall(). With this we no longer need to mess with the error decoration and handling any more - there is no point in handling the JS error occurred during bootstrapping by ourselves, we should just crash or let the VM handle it. PR-URL: nodejs#24775 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9a5984d - Browse repository at this point
Copy the full SHA 9a5984dView commit details -
lib: remove duplicated noop function
PR-URL: nodejs#24770 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 373bbe7 - Browse repository at this point
Copy the full SHA 373bbe7View commit details -
src,lib: make process.binding('config') internal
PR-URL: nodejs#23400 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6afa46 - Browse repository at this point
Copy the full SHA b6afa46View commit details -
lib: remove unused NativeModule/NativeModule wraps
We now compile the native modules in C++ so these are no longer used. PR-URL: nodejs#24904 Refs:https://github.com/joyeecheung/node/commit/ bd765d6 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5bc4592 - Browse repository at this point
Copy the full SHA 5bc4592View commit details -
inspector: move process.binding to internalBinding
In places of process.binding('inspector'), migrate code to adapt internalBinding. PR-URL: nodejs#24931 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e05e5b3 - Browse repository at this point
Copy the full SHA e05e5b3View commit details -
os: move process.binding('os') to internalBinding
PR-URL: nodejs#25087 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 181d03a - Browse repository at this point
Copy the full SHA 181d03aView commit details -
lib: remove internalBinding('config').pendingDeprecation
Instead use `require('internal/options').getOptionValue('--pending-deprecation')` PR-URL: nodejs#24962 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4cb9036 - Browse repository at this point
Copy the full SHA 4cb9036View commit details -
lib: expose all type checks from the internal types module
Combine all type checks on the internal types module and do not use the types binding anywhere else anymore. This makes sure all of those checks exist when required. PR-URL: nodejs#25149 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7d90f03 - Browse repository at this point
Copy the full SHA 7d90f03View commit details