Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 5.12.0 #25347

Merged
merged 1 commit into from
Jan 7, 2019
Merged

tools: update ESLint to 5.12.0 #25347

merged 1 commit into from
Jan 7, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 4, 2019

Update ESLint to 5.12.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2142/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 4, 2019
Trott
Trott approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at that beautiful tiny 37-file diff!

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 5, 2019
@cjihrig
tools: update ESLint to 5.12.0
ec5884a 
Update ESLint to 5.12.0.

PR-URL: nodejs#25347
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@cjihrig cjihrig merged commit ec5884a into nodejs:master Jan 7, 2019
@cjihrig cjihrig deleted the eslint branch January 7, 2019 13:52
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@cjihrig @addaleax
tools: update ESLint to 5.12.0
ee4c46c 
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
tools: update ESLint to 5.12.0
e42e327 
Update ESLint to 5.12.0.

PR-URL: nodejs#25347
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@cjihrig @BridgeAR
tools: update ESLint to 5.12.0
d378e6b 
Update ESLint to 5.12.0.

PR-URL: nodejs#25347
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig @BethGriggs
tools: update ESLint to 5.12.0
2984419 
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@cjihrig @BethGriggs
tools: update ESLint to 5.12.0
8b872e5 
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
tools: update ESLint to 5.12.0
21dc7cc 
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@Trott Trott Trott approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @fhinkel @Trott @hiroppy