util: format() now formats bigint and booleans
#25046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to distinguish them from other data types.
nodejs-github-bot
added
the
util
jasnell
approved these changes
Dec 15, 2018
BridgeAR
added
the
author ready
|
@nodejs/util This could use another review. |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Dec 19, 2018
This is necessary to distinguish them from other data types. PR-URL: nodejs#25046 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
|
Landed in 0f58ae3 |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This is necessary to distinguish them from other data types. PR-URL: nodejs#25046 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to distinguish them from other data types.
I also added a test for
formatWithOptionswhich was untested so far and which was necessary to actually see which types are passed through toinspect.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes